Skip to content

fix: propagate trace context end-to-end for agent Services #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
syn-zhu wants to merge 3 commits into
base: main
Choose a base branch
from
+120 −32
Open

fix: propagate trace context end-to-end for agent Services #1297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a48fbcf
fix: propagate trace context and enable A2A discovery for agent Services
syn-zhu Feb 24, 2026
11c4d7e
fix: propagate traceparent/tracestate headers from controller to agen…
syn-zhu Feb 24, 2026
5fd64e0
fix: address review feedback for trace context propagation
syn-zhu Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions go/core/internal/controller/translator/agent/adk_api_translator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -544,9 +544,10 @@ func (a *adkApiTranslator) buildManifest(
Spec: corev1.ServiceSpec{
Selector: selectorLabels,
Ports: []corev1.ServicePort{{
Name: "http",
Port: dep.Port,
TargetPort: intstr.FromInt(int(dep.Port)),
Name: "http",
Port: dep.Port,
TargetPort: intstr.FromInt(int(dep.Port)),
AppProtocol: ptr.To("kgateway.dev/a2a"),
Copy link
Contributor

@onematchfox onematchfox Mar 5, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whilst I'm completely for integrating with other projects, should this really be a hard-coded value that is applied to all Agents (regardless of whether users actually make use of KGateway/AgentGateway)?

What happens when this value changes; there seems to be a bit of a split going on between kgateway and agentgateway - so what would happen if this changes from kgateway.dev/a2a to agentgateway.dev/a2a? And what happens if I want to use a different appProtocol for whatever reason? Or, what happens if I only want some agents (not all) to be picked up via the A2A plugin?

Maybe a better approach here would be to allow users to configure this via the Agent CRD instead?

Copy link
Author

@syn-zhu syn-zhu Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a better approach here would be to allow users to configure this via the Agent CRD instead?

Completely agree, and was just thinking to make this change myself. Will update the PR

}},
Type: corev1.ServiceTypeClusterIP,
},
Expand Down
3 changes: 2 additions & 1 deletion ...ore/internal/controller/translator/agent/testdata/outputs/agent_with_allowed_headers.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,7 @@
"spec": {
"ports": [
{
"appProtocol": "kgateway.dev/a2a",
"name": "http",
"port": 8080,
"targetPort": 8080
Expand All @@ -298,4 +299,4 @@
}
}
]
}
}
3 changes: 2 additions & 1 deletion go/core/internal/controller/translator/agent/testdata/outputs/agent_with_code.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,7 @@
"spec": {
"ports": [
{
"appProtocol": "kgateway.dev/a2a",
"name": "http",
"port": 8080,
"targetPort": 8080
Expand All @@ -293,4 +294,4 @@
}
}
]
}
}
3 changes: 2 additions & 1 deletion ...ternal/controller/translator/agent/testdata/outputs/agent_with_cross_namespace_tools.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,7 @@
"spec": {
"ports": [
{
"appProtocol": "kgateway.dev/a2a",
"name": "http",
"port": 8080,
"targetPort": 8080
Expand All @@ -304,4 +305,4 @@
}
}
]
}
}
3 changes: 2 additions & 1 deletion go/core/internal/controller/translator/agent/testdata/outputs/agent_with_custom_sa.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,7 @@
"spec": {
"ports": [
{
"appProtocol": "kgateway.dev/a2a",
"name": "http",
"port": 8080,
"targetPort": 8080
Expand All @@ -257,4 +258,4 @@
}
}
]
}
}
3 changes: 2 additions & 1 deletion ...ore/internal/controller/translator/agent/testdata/outputs/agent_with_http_toolserver.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,7 @@
"spec": {
"ports": [
{
"appProtocol": "kgateway.dev/a2a",
"name": "http",
"port": 8080,
"targetPort": 8080
Expand All @@ -297,4 +298,4 @@
}
}
]
}
}
3 changes: 2 additions & 1 deletion go/core/internal/controller/translator/agent/testdata/outputs/agent_with_mcp_service.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,7 @@
"spec": {
"ports": [
{
"appProtocol": "kgateway.dev/a2a",
"name": "http",
"port": 8080,
"targetPort": 8080
Expand All @@ -293,4 +294,4 @@
}
}
]
}
}
3 changes: 2 additions & 1 deletion go/core/internal/controller/translator/agent/testdata/outputs/agent_with_nested_agent.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,7 @@
"spec": {
"ports": [
{
"appProtocol": "kgateway.dev/a2a",
"name": "http",
"port": 8080,
"targetPort": 8080
Expand All @@ -291,4 +292,4 @@
}
}
]
}
}
1 change: 1 addition & 0 deletions go/core/internal/controller/translator/agent/testdata/outputs/agent_with_passthrough.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,7 @@
"spec": {
"ports": [
{
"appProtocol": "kgateway.dev/a2a",
"name": "http",
"port": 8080,
"targetPort": 8080
Expand Down
3 changes: 2 additions & 1 deletion go/core/internal/controller/translator/agent/testdata/outputs/agent_with_proxy.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,7 @@
"spec": {
"ports": [
{
"appProtocol": "kgateway.dev/a2a",
"name": "http",
"port": 8080,
"targetPort": 8080
Expand All @@ -304,4 +305,4 @@
}
}
]
}
}
3 changes: 2 additions & 1 deletion ...nal/controller/translator/agent/testdata/outputs/agent_with_proxy_external_remotemcp.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,7 @@
"spec": {
"ports": [
{
"appProtocol": "kgateway.dev/a2a",
"name": "http",
"port": 8080,
"targetPort": 8080
Expand All @@ -293,4 +294,4 @@
}
}
]
}
}
3 changes: 2 additions & 1 deletion ...ore/internal/controller/translator/agent/testdata/outputs/agent_with_proxy_mcpserver.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,7 @@
"spec": {
"ports": [
{
"appProtocol": "kgateway.dev/a2a",
"name": "http",
"port": 8080,
"targetPort": 8080
Expand All @@ -296,4 +297,4 @@
}
}
]
}
}
3 changes: 2 additions & 1 deletion ...ntroller/translator/agent/testdata/outputs/agent_with_proxy_mcpserver_custom_timeout.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,7 @@
"spec": {
"ports": [
{
"appProtocol": "kgateway.dev/a2a",
"name": "http",
"port": 8080,
"targetPort": 8080
Expand All @@ -296,4 +297,4 @@
}
}
]
}
}
3 changes: 2 additions & 1 deletion go/core/internal/controller/translator/agent/testdata/outputs/agent_with_proxy_service.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,7 @@
"spec": {
"ports": [
{
"appProtocol": "kgateway.dev/a2a",
"name": "http",
"port": 8080,
"targetPort": 8080
Expand All @@ -295,4 +296,4 @@
}
}
]
}
}
3 changes: 2 additions & 1 deletion ...ternal/controller/translator/agent/testdata/outputs/agent_with_scheduling_attributes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,7 @@
"spec": {
"ports": [
{
"appProtocol": "kgateway.dev/a2a",
"name": "http",
"port": 8080,
"targetPort": 8080
Expand All @@ -316,4 +317,4 @@
}
}
]
}
}
3 changes: 2 additions & 1 deletion ...re/internal/controller/translator/agent/testdata/outputs/agent_with_security_context.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,7 @@
"spec": {
"ports": [
{
"appProtocol": "kgateway.dev/a2a",
"name": "http",
"port": 8080,
"targetPort": 8080
Expand All @@ -313,4 +314,4 @@
}
}
]
}
}
3 changes: 2 additions & 1 deletion go/core/internal/controller/translator/agent/testdata/outputs/agent_with_skills.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,7 @@
"spec": {
"ports": [
{
"appProtocol": "kgateway.dev/a2a",
"name": "http",
"port": 8080,
"targetPort": 8080
Expand All @@ -323,4 +324,4 @@
}
}
]
}
}
3 changes: 2 additions & 1 deletion go/core/internal/controller/translator/agent/testdata/outputs/agent_with_streaming.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,7 @@
"spec": {
"ports": [
{
"appProtocol": "kgateway.dev/a2a",
"name": "http",
"port": 8080,
"targetPort": 8080
Expand All @@ -289,4 +290,4 @@
}
}
]
}
}
3 changes: 2 additions & 1 deletion ...ontroller/translator/agent/testdata/outputs/agent_with_system_message_from_configmap.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,7 @@
"spec": {
"ports": [
{
"appProtocol": "kgateway.dev/a2a",
"name": "http",
"port": 8080,
"targetPort": 8080
Expand All @@ -282,4 +283,4 @@
}
}
]
}
}
3 changes: 2 additions & 1 deletion ...l/controller/translator/agent/testdata/outputs/agent_with_system_message_from_secret.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,7 @@
"spec": {
"ports": [
{
"appProtocol": "kgateway.dev/a2a",
"name": "http",
"port": 8080,
"targetPort": 8080
Expand All @@ -282,4 +283,4 @@
}
}
]
}
}
3 changes: 2 additions & 1 deletion go/core/internal/controller/translator/agent/testdata/outputs/anthropic_agent.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,7 @@
"spec": {
"ports": [
{
"appProtocol": "kgateway.dev/a2a",
"name": "http",
"port": 8080,
"targetPort": 8080
Expand All @@ -281,4 +282,4 @@
}
}
]
}
}
3 changes: 2 additions & 1 deletion go/core/internal/controller/translator/agent/testdata/outputs/basic_agent.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,7 @@
"spec": {
"ports": [
{
"appProtocol": "kgateway.dev/a2a",
"name": "http",
"port": 8080,
"targetPort": 8080
Expand All @@ -289,4 +290,4 @@
}
}
]
}
}
3 changes: 2 additions & 1 deletion go/core/internal/controller/translator/agent/testdata/outputs/bedrock_agent.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,7 @@
"spec": {
"ports": [
{
"appProtocol": "kgateway.dev/a2a",
"name": "http",
"port": 8080,
"targetPort": 8080
Expand All @@ -295,4 +296,4 @@
}
}
]
}
}
3 changes: 2 additions & 1 deletion go/core/internal/controller/translator/agent/testdata/outputs/ollama_agent.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,7 @@
"spec": {
"ports": [
{
"appProtocol": "kgateway.dev/a2a",
"name": "http",
"port": 8080,
"targetPort": 8080
Expand All @@ -284,4 +285,4 @@
}
}
]
}
}
3 changes: 2 additions & 1 deletion go/core/internal/controller/translator/agent/testdata/outputs/tls-with-custom-ca.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,7 @@
"spec": {
"ports": [
{
"appProtocol": "kgateway.dev/a2a",
"name": "http",
"port": 8080,
"targetPort": 8080
Expand All @@ -299,4 +300,4 @@
}
}
]
}
}
3 changes: 2 additions & 1 deletion go/core/internal/controller/translator/agent/testdata/outputs/tls-with-disabled-verify.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,7 @@
"spec": {
"ports": [
{
"appProtocol": "kgateway.dev/a2a",
"name": "http",
"port": 8080,
"targetPort": 8080
Expand All @@ -286,4 +287,4 @@
}
}
]
}
}
3 changes: 2 additions & 1 deletion ...e/internal/controller/translator/agent/testdata/outputs/tls-with-system-cas-disabled.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,7 @@
"spec": {
"ports": [
{
"appProtocol": "kgateway.dev/a2a",
"name": "http",
"port": 8080,
"targetPort": 8080
Expand All @@ -299,4 +300,4 @@
}
}
]
}
}
Loading
Loading