Skip to content

Bump @poupe/eslint-config to 0.8.4#5

Merged
amery merged 2 commits intomainfrom
chore/eslint-config-0.8.4
Mar 24, 2026
Merged

Bump @poupe/eslint-config to 0.8.4#5
amery merged 2 commits intomainfrom
chore/eslint-config-0.8.4

Conversation

@amery
Copy link
Copy Markdown
Contributor

@amery amery commented Mar 24, 2026

Summary

  • Bump @poupe/eslint-config from 0.8.3 to 0.8.4
  • Remove local arrow-parens override — now enforced upstream
  • Remove unused GLOB_SRC import from eslint.config.mjs

Test plan

  • pnpm precommit passes
  • CI Build passes
  • CI Compat passes (Node 18, 20, 22)

Summary by CodeRabbit

  • Changed
    • Moved a compatibility test to use the project test script instead of a hard-coded command.
    • Removed a file-scoped lint override; rule is now enforced from the shared config.
  • Chores
    • Bumped a development dependency to a newer patch version.
    • Added a new script to run compatibility tests and updated the changelog to reflect these updates.

arrow-parens is now enforced upstream; remove the local
override and GLOB_SRC import from eslint.config.mjs.

Signed-off-by: Alejandro Mery <amery@apptly.co>
@amery amery added the dependencies Dependency updates label Mar 24, 2026
@amery amery self-assigned this Mar 24, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 09d5fced-a88e-4580-8afd-f95fdf917842

📥 Commits

Reviewing files that changed from the base of the PR and between 548ccd3 and d2d0b76.

📒 Files selected for processing (3)
  • .github/workflows/compat.yml
  • CHANGELOG.md
  • package.json

📝 Walkthrough

Walkthrough

Removed a local ESLint override and its unused import, bumped @poupe/eslint-config devDependency, added a test:compat npm script, and updated the GitHub Actions compat step to run that script; CHANGELOG updated accordingly.

Changes

Cohort / File(s) Summary
ESLint config
eslint.config.mjs
Removed GLOB_SRC usage and deleted the second defineConfig that applied @stylistic/arrow-parens; file now only defines ignores.
Package manifest
package.json
Added test:compat script (node src/__tests__/compat.mjs) and bumped devDependency @poupe/eslint-config from ^0.8.3 to ^0.8.4.
CI workflow
.github/workflows/compat.yml
Changed the Compat test step to run the package script (pnpm test:compat) instead of invoking the Node entrypoint directly.
Changelog
CHANGELOG.md
Documented the dependency bump and the CI change (compat workflow now uses pnpm test:compat) under Unreleased → Changed.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • kagal-dev/json-template#4 — introduced the compat workflow and test script; related because this PR switches the workflow to run the package script and adds the script here.

Suggested labels

ci

Poem

A rabbit nibbles at cluttered lines,
Pared rules and scripts in tidy piles,
Tests hop to a scripted tune,
Dependencies nudged one step sooner,
Little cleanups, many happy smiles 🐇✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the primary change: bumping the @poupe/eslint-config dependency from 0.8.3 to 0.8.4, which is the main focus of the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/eslint-config-0.8.4

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@socket-security
Copy link
Copy Markdown

socket-security bot commented Mar 24, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​poupe/​eslint-config@​0.8.3 ⏵ 0.8.47610010095 +1100

View full report

Signed-off-by: Alejandro Mery <amery@apptly.co>
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 24, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@kagal/json-template@5

commit: d2d0b76

@amery amery merged commit ebc1693 into main Mar 24, 2026
10 checks passed
@amery amery deleted the chore/eslint-config-0.8.4 branch March 24, 2026 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Dependency updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant