-
Notifications
You must be signed in to change notification settings - Fork 3
Formatting Java source code #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
682ee98
3172108
0ea5b1c
5a69b93
87dab71
eb9e280
d1b4a9e
d372b57
2f158f2
3f46848
004184d
cdae3ff
aa477b3
e42e411
7cc32dc
7b883e8
56d86d4
76957ee
8377f39
7b97734
318ccd4
e1f9091
41f5714
38e4056
c8bf9f8
d72998c
0edb6bb
ee9366d
6da46b7
128e1e3
e868a25
bf2c5bd
4b01aff
05068bd
11c4f82
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,3 +2,6 @@ | |
| /jython-jbang-catalog.iml | ||
|
|
||
| /.vscode/ | ||
| /.gradle/ | ||
| /build/ | ||
| /target/ | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| import dev.jbang.gradle.tasks.JBangTask | ||
|
|
||
| // Apply the standard Java plugin | ||
wfouche marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| plugins { | ||
| id 'java' | ||
| // Apply the Spotless plugin (using the same version as in the Kotlin DSL) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To get the Gradle
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not needed in the revised implementation. |
||
| id 'com.diffplug.spotless' version '7.2.1' | ||
wfouche marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| id 'dev.jbang' version '0.3.0' | ||
| } | ||
|
|
||
| // Standard repository configuration | ||
| repositories { | ||
| mavenCentral() | ||
| } | ||
|
|
||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Then here, we need to specify these dependencies: and to minimally configure the
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Following a slightly different approach by using the JBang Gradle plugin https://plugins.gradle.org/plugin/dev.jbang and then just running TestJythonCli.java as we run it currently. Created new task tasks.register("runTests", JBangTask) {
// Specify the script file to run
script = "src/test/java/TestJythonCli.java"
// Optional: Pass arguments to the script
jbangArgs = ["--java", "17"]
args = ["execute", "--disable-ansi-colors", "--select-class=TestJythonCli"]
}
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it is fine to have a target that runs the tests the way we do on GitHub. I confirm this target runs at the console for me. It is not a substitute for the changes I suggested. |
||
| // === Spotless Configuration === | ||
| spotless { | ||
| // Define the formatting rules for Java files | ||
| java { | ||
| eclipse().configFile('tools/eclipse-java-formatter/Jython-2017-v2.xml') | ||
|
|
||
| importOrder() | ||
| removeUnusedImports() | ||
| toggleOffOn() | ||
| } | ||
| } | ||
|
|
||
| // Define a custom task to run jython-cli tests | ||
| tasks.register("runTests", JBangTask) { | ||
| // Specify the script file to run | ||
| script = "src/test/java/TestJythonCli.java" | ||
|
|
||
| // Optional: Pass arguments to the script | ||
| jbangArgs = ["--java", "17"] | ||
| args = ["execute", "--disable-ansi-colors", "--select-class=TestJythonCli"] | ||
| } | ||
|
|
||
| // Add a standard task for running the application | ||
| tasks.register('hello') { | ||
| doLast { | ||
| println 'Spotless is now configured using Groovy DSL with Google Java Format. To format your code, run:' | ||
| println './gradlew spotlessApply' | ||
| println 'To check if files need formatting (useful for CI), run:' | ||
| println './gradlew spotlessCheck' | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.3-bin.zip | ||
| networkTimeout=10000 | ||
| validateDistributionUrl=true | ||
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gradle potentially confers some advantages in terms of editing and debugging from the IDE, which has always been a pain point when reviewing. VSCode recognises this as a Gradle project, which means the Gradle menu has just appeared, and the
spotlessApplytask may be run from it.However, it is not properly set up as a Gradle Java project with the right structure and dependencies, so VSCode does not recognise the source as belonging to the project, and continues to give me red ink about the imports and won't debug the cli.
I think a little more work (and letting Gradle bully you into
mainandtestsource trees) will yield a lot.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As an initial step, I've moved both Java files to
src/main/java.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good first step. With that change, I find I can finally stop the IDE grumbling at me, with some additions to just this file, which I'll pass on next.