Skip to content

Add labels in popups #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ezheidtmann wants to merge 2 commits into
base: master
Choose a base branch
from
+12 −1
Open

Add labels in popups #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2655500
Add labels in popups
ezheidtmann Nov 18, 2015
3ed860d
No matter what happened, we don't have a label
ezheidtmann Nov 18, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions mplleaflet/leaflet_renderer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,14 @@ def draw_path(self, data, coordinates, pathcodes, style,
minx=corner[0],
miny=corner[1],
)

try:
label = mplobj.get_label()
except:
label = None

properties = {'html': svg,
'label': label,
'anchor_x': -corner[0],
'anchor_y': -corner[1]}
else:
Expand Down
6 changes: 5 additions & 1 deletion mplleaflet/templates/base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,11 @@
iconAnchor: [feature.properties.anchor_x,
feature.properties.anchor_y],
className: 'empty'}); // What can I do about empty?
return L.marker(latlng, {icon: icon});
var marker = L.marker(latlng, {icon: icon});
if (feature.properties.label) {
marker.bindPopup('<pre>' + feature.properties.label + '</pre>');
}
return marker;
}
});
gj.addTo(map);
Expand Down