feat: add horizontal pager for swipe navigation between tabs#16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add swipe gesture navigation between tabs using
HorizontalPageron Android andTabViewwith.pagestyle on iOS. The bottom bar is lifted out of individual screens into the rootApp/iOSAppso it stays fixed while page content swipes underneath.Changes
when/mutableStateOftab switching inApp.ktwithHorizontalPagerinside aBoxlayout, withWornBottomBaroverlaid at the bottomswitchtab switching iniOSApp.swiftwithTabView(.page)andWornBottomBarplaced outside theTabViewWornBottomBarfrom all 5 screen Scaffolds (Android) and all 5 screen views (iOS)onTabSelectedparameters from scaffold-level functionsBgPagebackground on the rootBoxto prevent white showing behind the bottom barTest plan
Checklist
./gradlew detektpasses