fix: improve error handling UI for Gaps and Try It screens#14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix error handling for the Gaps and Try It screens when the Claude API key is invalid or there is a request error. Previously, the Gaps screen showed a loading spinner forever on API failure, and both screens displayed raw/technical error messages (e.g., JSON parse errors). Now,
ClaudeApiClientchecks HTTP status codes and returns user-friendly messages, the Gaps screen displays a proper error state with retry, and the Try It screen's inline error was upgraded to a styled error content with retry button.Changes
ClaudeApiClient.sendRequest()— maps 401, 429, 5xx to user-friendly error messages and catches network exceptionsClaudeErrorResponse/ClaudeErrorDetailmodels toClaudeApiModels.ktErrorContentcomposable to AndroidGapsScreenwith error icon, message, and retry buttonerrorContent(message:)view to iOSGapsScreen.swiftwith matching designErrorMessagewith styledErrorContent(icon + message + retry) on AndroidTryItScreenerrorMessage()with stylederrorContent(message:)on iOSTryItScreen.swiftcommon_retrystring resource to all 4 locale files (en/pt-BR for Android and iOS)Test plan
Checklist
./gradlew detektpasses