Concept of an application which components run within#4
Open
oliyh wants to merge 3 commits intojuxt:masterfrom
Open
Concept of an application which components run within#4oliyh wants to merge 3 commits intojuxt:masterfrom
oliyh wants to merge 3 commits intojuxt:masterfrom
Conversation
Member
|
Could you squash the commits into 1 please, or split the PR... |
Member
Author
|
Squashed to a sensible level |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The most important change here is that system maps can have a
:name. Settings for the application are fetched and merged into the settings for each component so that they are available throughout the application.Furthermore application settings are "deep merged" with the other settings resulting in the ability to override component level settings at an application level.
Other bits include improving some tests, removing the zk client in favour of the curator client and changing the file config supplier so that it can look for multiple files.