Non-blocking service start, add .local to URLs, and fallback when config is missing#8
Open
justyn-clark wants to merge 1 commit intomainfrom
Open
Non-blocking service start, add .local to URLs, and fallback when config is missing#8justyn-clark wants to merge 1 commit intomainfrom
.local to URLs, and fallback when config is missing#8justyn-clark wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ports start <service>returns immediately..localwhen not provided explicitly.Description
start_serviceto useCommand::spawn()(non-blocking) and emit aprintln!confirmation instead of waiting onstatus()insrc/lib.rs.load_config_or_empty(path: &Path) -> Result<Config>and used it for theList,Tui,Doctor, andUrlscode paths so the CLI handles a missing config file gracefully.Urlsto append.localwhen the derived hostname does not already end with.local.cargo fmt, resulting in minor formatting adjustments in a few modules.Testing
cargo fmt --check, which passed in this environment.cargo test, which failed to run due to crates.io index/network access errors in the execution environment (dependency fetch failed with HTTP 403).cargo test --offline, which failed because required dependencies were not present in the local cache so tests could not be executed here.Codex Task