Skip to content

Made it so that captcha errors are associated with the captcha field instead of the whole form #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kajic wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Made it so that captcha errors are associated with the captcha field instead of the whole form #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions math_captcha/forms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,18 @@ def math_clean(form):
assert len(test_secret) == 40 and question
except (TypeError, AssertionError):
# problem decoding, junky data
raise forms.ValidationError('Invalid token')
form._errors['math_captcha_field'] = form.error_class(["Invalid token"])
del form.cleaned_data['math_captcha_field']
except KeyError:
return

if encode(question) != form.cleaned_data['math_captcha_question']:
# security problem, hack attempt
raise forms.ValidationError('Invalid token')
form._errors['math_captcha_field'] = form.error_class(["Invalid token"])
del form.cleaned_data['math_captcha_field']
if eval(question) != value:
raise forms.ValidationError('Wrong answer, try again')

form._errors['math_captcha_field'] = form.error_class(["Wrong answer, try again"])
del form.cleaned_data['math_captcha_field']

class MathCaptchaModelForm(forms.ModelForm):
"""
Expand Down