fix: complete Responses image generation calls with results#596
Open
SantaDiegoKairos wants to merge 1 commit into
Open
fix: complete Responses image generation calls with results#596SantaDiegoKairos wants to merge 1 commit into
SantaDiegoKairos wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalize OpenAI Responses
image_generation_callitems that already contain a finalresultso they are returned withstatus: "completed"instead of preserving an upstream/intermediatestatus: "generating".Why
Some Responses image generation flows can produce a completed response and a valid base64 PNG in
image_generation_call.result, while the output item still hasstatus: "generating".That shape is confusing for strict Responses clients: the image payload is present, but the item still looks unfinished. In practice this can lead clients to treat the image result as blank or still pending.
The affected shapes are:
response.output[]response.output_item.done.itemresponse.completed.response.output[]The fix is intentionally conservative: only
image_generation_callitems with a non-emptyresultare marked completed. In-progress image calls without a result are left unchanged.Validation
node --check src/utils/common.js npm test -- --runInBand tests/responses-image-status-normalize.test.jsLocal result:
Also validated against a live OpenAI Responses-compatible route:
response.status=completed, image item has non-emptyresult, normalized tostatus=completedresponse.output_item.done.item.status=completedresponse.completed.output[0].status=completed