fix(ws): relax effect WebSocket ping/pong cadence to reduce flapping#7
Merged
Merged
Conversation
effect's default pinger writes a ping every 5s and tears the socket down on a single missed pong. Over lossy/reordering links (e.g. WireGuard/Tailscale) that churns the UI WebSocket and causes reconnect flapping. Patch `makePinger` to: - ping every 15s instead of 5s, and - only fail after 3 consecutive missed pongs (`MAX_MISSED_PONGS`) instead of 1, tracked via a `missedPongs` counter that resets on pong. The patch also threads optional `onPing`/`onPong` connection hooks through the pinger. Regenerated `patches/effect@4.0.0-beta.78.patch` and updated the `patch_hash` references in `pnpm-lock.yaml`. See pingdotgg#3054. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
github-actions
Bot
added
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
effect's default RPC pinger writes a ping every 5s and tears the socket down on a single missed pong. Over lossy / packet-reordering links (e.g. WireGuard / Tailscale) that churns the UI WebSocket and causes reconnect flapping.
Changes
Patch
makePingerin the vendored effect patch to:PING_INTERVAL), andMAX_MISSED_PONGS) instead of 1, tracked via amissedPongscounter that resets on pong.The patch also threads optional
onPing/onPongconnection hooks through the pinger.patches/effect@4.0.0-beta.78.patch.patch_hashreferences inpnpm-lock.yaml(c502bc…→6923666…, 114 occurrences).Refs pingdotgg#3054.
🤖 Generated with Claude Code