fix(auth): treat Tailscale Serve loopback host as remote-reachable#4
Merged
Merged
Conversation
When Tailscale Serve is enabled it proxies the loopback-bound backend onto the tailnet, so the server is reachable from other devices even though `config.host` stays on 127.0.0.1. Previously the auth policy keyed solely off the bind host and selected a local-only policy in that case, skipping the one-time-token bootstrap required for remote access. Treat the server as remote-reachable whenever `tailscaleServeEnabled` is set, in addition to the existing wildcard / non-loopback host checks, so remote clients get the `remote-reachable` policy with one-time-token bootstrap. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
github-actions
Bot
added
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When Tailscale Serve is enabled it proxies the loopback-bound backend onto the tailnet, so the server is reachable from other devices even though
config.hoststays on127.0.0.1. TheEnvironmentAuthPolicypreviously keyed solely off the bind host and therefore selected a local-only policy in that case, skipping the one-time-token bootstrap that remote clients need.This change treats the server as remote-reachable whenever
tailscaleServeEnabledis set, in addition to the existing wildcard / non-loopback host checks.Changes
EnvironmentAuthPolicy.makenow factorsconfig.tailscaleServeEnabledintoisRemoteReachable.mode: "web"+ loopback host + Tailscale Serve case, asserting aremote-reachablepolicy withone-time-tokenbootstrap.🤖 Generated with Claude Code