Skip to content

fix(stylelint-config-pie): DSW-3767 load extra tokens from pie-css correctly#2725

Merged
raoufswe merged 3 commits intomainfrom
dsw-3767-fix-tokens-loading
Mar 19, 2026
Merged

fix(stylelint-config-pie): DSW-3767 load extra tokens from pie-css correctly#2725
raoufswe merged 3 commits intomainfrom
dsw-3767-fix-tokens-loading

Conversation

@raoufswe
Copy link
Copy Markdown
Member

@raoufswe raoufswe commented Mar 19, 2026

Describe your changes (can list changeset entries if preferable)

  • Updated the stylelint rule for design tokens to load tokens from pie-css as it includes additional tokens and fall back to the tokens package as the source of truth when not.

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.
  • I have added thorough tests where applicable (unit / component / visual).
  • [-] I have reviewed the PIE Storybook/PIE Docs PR preview.
  • [-] I have reviewed visual test updates properly before approving.
  • If changes will affect consumers of the package, I have created a changeset entry.
  • [-] If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.
  • I have filled out the DS Review Tracker checklist (Moving PR to "Ready to Review")

Not-applicable Checklist items

Please move any Author checklist items that do not apply to this pull request here.


Testing

How do I test my changes?

Task Link
Aperture PR 🔗
NextJS 15 deployment 🔗
NextJS 14 deployment 🔗
Nuxt 3 deployment 🔗
Vanilla deployment 🔗

Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1

  • [-] I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • [-] I have reviewed the Aperture changes (if added)
  • [-] If there are visual test updates, I have reviewed them.

Reviewer 2

  • [-] I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • [-] I have reviewed the Aperture changes (if added)
  • [-] If there are visual test updates, I have reviewed them.

@raoufswe raoufswe requested a review from a team as a code owner March 19, 2026 12:41
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 19, 2026

🦋 Changeset detected

Latest commit: 35ac656

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@justeattakeaway/stylelint-config-pie Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@raoufswe
Copy link
Copy Markdown
Member Author

/snapit

@pie-design-system-bot
Copy link
Copy Markdown
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Copy Markdown
Contributor

@raoufswe Your snapshot has been published to npm!

Test the snapshot by updating your package.json with the newly-published version:

yarn up @justeattakeaway/stylelint-config-pie@0.0.0-snapshot-release-20260319125019

@raoufswe raoufswe merged commit 6d778f1 into main Mar 19, 2026
28 of 29 checks passed
@raoufswe raoufswe deleted the dsw-3767-fix-tokens-loading branch March 19, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants