Skip to content

docs(pie-docs): DSW-2732 add forms pattern pages#2711

Merged
nindyahapsari merged 13 commits intomainfrom
DSW-2732-add-forms-pattern-pages
Mar 25, 2026
Merged

docs(pie-docs): DSW-2732 add forms pattern pages#2711
nindyahapsari merged 13 commits intomainfrom
DSW-2732-add-forms-pattern-pages

Conversation

@nindyahapsari
Copy link
Copy Markdown
Contributor

@nindyahapsari nindyahapsari commented Mar 11, 2026

Please click the Preview tab and select a different PR template if your change isn't for an existing web component.

PIE Docs Template
New Web Component Template

═══════════════════════════════════════════════════════════

Describe your changes (can list changeset entries if preferable)

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.
  • I have added thorough tests where applicable (unit / component / visual).
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have reviewed visual test updates properly before approving.
  • If changes will affect consumers of the package, I have created a changeset entry.
  • I have filled out the DS Review Tracker checklist (Moving PR to "Ready to Review")

Not-applicable Checklist items

Please move any Author checklist items that do not apply to this pull request here.

  • If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.

Testing

How do I test my changes?

Task Link
Aperture PR 🔗
NextJS 15 deployment 🔗
NextJS 14 deployment 🔗
Nuxt 3 deployment 🔗
Vanilla deployment 🔗

Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1 - @fernandofranca

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • [-] I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

Reviewer 2

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • [-] I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

@nindyahapsari nindyahapsari requested a review from a team as a code owner March 11, 2026 16:04
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 11, 2026

⚠️ No Changeset found

Latest commit: 4db3f70

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 1 package
Name Type
@justeattakeaway/pie-docs Minor

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nindyahapsari nindyahapsari added the work-in-progress This pull request is still a work in progress and may not be ready for review label Mar 11, 2026
@nindyahapsari nindyahapsari self-assigned this Mar 23, 2026
@nindyahapsari nindyahapsari removed work-in-progress This pull request is still a work in progress and may not be ready for review labels Mar 23, 2026
fernandofranca
fernandofranca previously approved these changes Mar 23, 2026
Copy link
Copy Markdown
Contributor

@fernandofranca fernandofranca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

Comment thread .changeset/smart-comics-switch.md Outdated
Comment thread .changeset/smart-comics-switch.md Outdated
Comment thread apps/pie-docs/src/patterns/forms/guidance/guidance.md Outdated
Co-authored-by: Fernando de França <448801+fernandofranca@users.noreply.github.com>
Comment thread apps/pie-docs/src/patterns/forms/guidance/guidance.md
@joshua-king-JET joshua-king-JET requested review from joshua-king-JET and removed request for joshua-king-JET March 25, 2026 10:18
@joshua-king-JET
Copy link
Copy Markdown

I have had a look from a design perspective and approve the changes made 👍

@nindyahapsari nindyahapsari removed the request for review from joshua-king-JET March 25, 2026 13:01
@nindyahapsari nindyahapsari merged commit 9034829 into main Mar 25, 2026
27 of 28 checks passed
@nindyahapsari nindyahapsari deleted the DSW-2732-add-forms-pattern-pages branch March 25, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants