Draft
Conversation
Owner
|
Hey Jon 👋 thanks for the PR. This seems like a good start. I agree with you, adding logging is a great idea. The app could be more verbose when it comes to how it obtains the proper handler/action combo. We could also add logs for the interactive route. I'm fine with the code changes. I would add a test or two for expectation of logs and then call it a day. Let me know if you want me to write the tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwing up a rough PR at the moment to get this logging idea out there.
For newcomers to the library it's useful to know when messages/interactions/events are unhandled and which are handled. Adding this logging gives some insight into this.
So far I've added the basic logging configuration and started adding some logging to the Router class so far.
Enjoying the library so far! Looking forward to the day when #4 is figured out.