Skip to content

fixup/experiment: replace std::system by boost.process to launch processes in a cross-platform way #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Klaim wants to merge 4 commits into from
Closed

fixup/experiment: replace std::system by boost.process to launch processes in a cross-platform way #685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f55b93e
dont use std::system to launch processes, it's cli api is system-depe…
Klaim Jan 21, 2026
25b0d7a
ignore root build dirs
Klaim Jan 22, 2026
f89a2e4
added missing boost dependency
Klaim Jan 22, 2026
d84a025
added missing boost packages dependencies
Klaim Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ docs/build/

# Build directory
build/
/build-*/

# generated kernel specs
/share/jupyter/kernels/xpython/kernel.json
Expand Down
4 changes: 4 additions & 0 deletions environment-dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,7 @@ dependencies:
- jupyter_kernel_test<0.8
- doctest
- pluggy=1.3
- libboost
- libboost-devel
- libboost-headers

7 changes: 5 additions & 2 deletions test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,10 @@ if(CMAKE_CXX_COMPILER_ID MATCHES MSVC)
endif()

find_package(Threads)
find_package(doctest)
find_package(doctest REQUIRED)

cmake_policy(SET CMP0167 OLD) # use find boost from old cmake
find_package(Boost REQUIRED COMPONENTS process filesystem)

include_directories(${GTEST_INCLUDE_DIRS} SYSTEM)

Expand All @@ -70,7 +73,7 @@ set_target_properties(test_xeus_python PROPERTIES
)

include_directories(${PYTHON_INCLUDE_DIRS})
target_link_libraries(test_xeus_python ${PYTHON_LIBRARIES} xeus-zmq doctest::doctest ${CMAKE_THREAD_LIBS_INIT})
target_link_libraries(test_xeus_python ${PYTHON_LIBRARIES} xeus-zmq doctest::doctest Boost::headers Boost::filesystem Boost::process ${CMAKE_THREAD_LIBS_INIT})
target_include_directories(test_xeus_python PRIVATE ${XEUS_PYTHON_INCLUDE_DIR})

add_custom_target(xtest COMMAND test_xeus_python DEPENDS test_xeus_python)
Expand Down
Loading
Loading