Use minimal summary listener for Suite Engine#5711
Draft
mpkorstanje wants to merge 2 commits into
Draft
Conversation
mpkorstanje
commented
May 30, 2026
|
|
||
| @Override | ||
| public void testPlanExecutionStarted(TestPlan testPlan) { | ||
| this.testsFound.set(testPlan.countTestIdentifiers(TestIdentifier::isTest)); |
Member
Author
There was a problem hiding this comment.
Not happy with this yet. This is ultimately derived from the LauncherDiscoveryResult which we can access earlier. So this listener could be eliminated entirely.
The Suite engine uses the `SummaryGeneratingListener` to track if any tests were discovered. After #5588 this fails because it now tries to construct a complete description of the failing test. This assumes that all ancestors of a test descriptor are in the plan. Which isn't true for plans from the SuiteEngine, as these are a subtree of the overall plan. Using a minimal implementation of the `SummaryGeneratingListener` we can avoid this problem.
mpkorstanje
force-pushed
the
rien/minimal-suite-summary-listener
branch
from
213cede to
5eb4a47
Compare
✅ All tests passed ✅🏷️ Commit: 5eb4a47 Learn more about TestLens at testlens.app. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Suite engine uses the
SummaryGeneratingListenerto track ifany tests were discovered. After #5588 this fails because it now tries
to construct a complete description of the failing test. This assumes
that all ancestors of a test descriptor are in the plan. Which isn't
true for plans from the SuiteEngine, as these are a subtree of the
overall plan.
Using a minimal implementation of the
SummaryGeneratingListenerwecan avoid this problem.
Fixes: #5710
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations