Highlight tags and branch names differently when they refer to the same commit#98
Open
BertrandSim wants to merge 4 commits intojunegunn:masterfrom
Open
Highlight tags and branch names differently when they refer to the same commit#98BertrandSim wants to merge 4 commits intojunegunn:masterfrom
BertrandSim wants to merge 4 commits intojunegunn:masterfrom
Conversation
added 4 commits
August 31, 2021 15:05
when tags and branch names are shown next to each other, they are _both_ highlighted with gvTag, or with gvMeta eg (tag: 0.0.0.9000, origin/master, origin/HEAD, master) eg (origin/master, origin/HEAD, master, tag: 0.0.0.9000) This commit fixes that: tags are highlighted with gvTag, while branch names are highlighted with gvMeta
highlight opening ( and ) with gvMeta hl group eg in (tag: 0.0.0.9000, origin/master, origin/HEAD, master) the ( is highlighted with gvTag, but ) is highlighted with gvMeta this commit highlights both ( and ) with gvMeta
In the previous commit,
lone tags such as (tag: feature)
have '(' and ')' highlighted with gvMeta,
while 'tag: feature' is highlighted with gvTag.
This looks odd.
Thus, the case of a single lone tag should be defined separately:
the '(' and ')' are included in the match, and
are highlighted with gvTag.
BertrandSim
force-pushed
the
syntax_meta_fix1
branch
from
2bfd9b3 to
4f9e7ee
Compare
Author
|
rebased on latest master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! I noticed that when tags and head refs (such as branch names) are placed side by side on the same line, the tags and head refs are highlighted in the same way. They are either both highlighted with
gvTag, or both withgvMeta.For example, in
both
tag: 0.0.0.9000andmastermatchgvTag.And in
both
tag: 0.0.0.9000andmastermatchgvMeta.This PR aims to fix this in the following way:
tag: xxxwithgvTag, and the parentheses and its other contents(...)withgvMeta,(tag: xxx)withgvTag.