test(dashboard): setup Vitest environment & add initial unit tests#549
Open
utact wants to merge 1 commit intojunaid33:masterfrom
Open
test(dashboard): setup Vitest environment & add initial unit tests#549utact wants to merge 1 commit intojunaid33:masterfrom
utact wants to merge 1 commit intojunaid33:masterfrom
Conversation
- 📦 Install vitest as a dev dependency - ⚙️ Configure vitest.config.ts (using node environment) - 📝 Add unit tests for features/dashboard/lib/sort.ts -▶️ Add 'test': 'vitest' script to package.json
👷 Deploy request for opensourcebuilders pending review.Visit the deploys page to approve it
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently, there is no testing infrastructure in the project. I've set up Vitest to start ensuring code reliability and added initial test cases for the
sortutility function.Motivation
While reviewing
features/dashboard/lib/sort.ts, I noticed it contains multiple layers of fallback logic (Query Params → Initial Sort → Preferred Fields → ID). Adding unit tests ensures this logic behaves consistently across different scenarios.Changes
vitestas a dev dependency.vitest.config.ts(usingnodeenvironment for performance).features/dashboard/lib/sort.ts."test": "vitest"script topackage.json.Verification
I verified the test coverage locally using
vitest run --coverage.The core logic in
sort.tshas achieved 100% Statement & Line Coverage, ensuring that all edge cases (fallback logic, invalid params) are handled correctly.Future Plan
If this PR is accepted, I'd love to contribute further by setting up a GitHub Actions workflow to run these tests automatically on every PR.