Support running e2e on macOS #15
Conversation
|
""" WalkthroughThe GitHub Actions workflow was updated to add macOS 13 as a supported runner in the selftest job matrix. Additionally, the composite GitHub Action now includes a conditional step to install Docker, Kind, Colima, Go, kubectl, Helm, and GNU sed on macOS runners using Homebrew, starts Colima with specific settings, and modifies the Changes
Sequence Diagram(s)sequenceDiagram
participant GitHub Actions Runner
participant Composite Action
participant Homebrew
participant Colima
GitHub Actions Runner->>Composite Action: Start job
alt If runner.os == macOS
Composite Action->>Homebrew: Install Docker, Kind, Colima, Go, kubectl, Helm, GNU sed
Composite Action->>Colima: Start Colima with CPU and memory limits
end
Composite Action->>Composite Action: Update /etc/hosts for dex deployment
alt If runner.os == macOS
Composite Action->>Composite Action: Map dex.dex.svc.cluster.local to 192.168.65.2
Composite Action->>Composite Action: Patch deploy_with_helm.sh with fixed IP
Composite Action->>Composite Action: Add Dex TLS cert to macOS system keychain
else
Composite Action->>Composite Action: Map dex.dex.svc.cluster.local to 127.0.0.1
Composite Action->>Composite Action: Update CA certificates via Linux method
end
Composite Action-->>GitHub Actions Runner: Continue workflow steps
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms (3)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/selftest.yml (1)
11-11: Add macOS-13 runner to the selftest matrix.Good catch on expanding test coverage to macOS. Confirmed that
runs-on: macos-13is supported and that theif: runner.os == 'macOS'guard in your composite action will execute as expected.Nit: To improve clarity, consider updating the comment:
- # arm-based macOS runners does not support nested virt + # Arm-based macOS runners do not support nested virtualizationaction.yml (1)
30-35: Install Docker, Kind, and Colima on macOS runners.This step correctly uses Homebrew to install the required container tools and starts Colima, with the
if: runner.os == 'macOS'guard ensuring it only runs on macOS hosts.Consider adding a
brew update --quietbefore installation to avoid stale formulas and reduce log noise:- name: Install Docker and Kind (macOS) if: runner.os == 'macOS' shell: bash run: | + brew update --quiet brew install --quiet colima docker kind colima start
NickCao
force-pushed
the
darwin
branch
4 times, most recently
from
888e5f8 to
9aa8e3d
Compare
NickCao
force-pushed
the
darwin
branch
2 times, most recently
from
55f2a3c to
99cd881
Compare
Summary by CodeRabbit