Support configuring urlPropsIgnore via appdef app settings#1602
Support configuring urlPropsIgnore via appdef app settings#1602
Conversation
Co-authored-by: jumpinjackie <563860+jumpinjackie@users.noreply.github.com>
|
@copilot Integrate latest changes from master and revalidate your current work |
Done. Merged master into the branch (commit d58ad2a) — no conflicts in the changed files. All 656 tests pass (93 test files, including the 92 test files from master and the new Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot What would be a suitable manual test plan to verify this works? |
Here is a suitable manual test plan: PrerequisitesA working MapGuide viewer deployment (or the local dev server Test 1 — Baseline (no
|
urlPropsIgnorecould only be set via viewer mount options (IAppProps.urlPropsIgnore), requiring HTML template modification. This adds support for configuring it via an app setting in the loaded Application Definition — the established pattern for avoiding template changes.Changes
src/containers/app.tsxAPP_SETTING_URL_PROPS_IGNORE = "urlPropsIgnore"constant for the app setting keygetEffectiveUrlPropsIgnore(propIgnore, settingsValue)helper that merges the prop value with a comma-separated app settings valueuseCustomAppSettings()call inAppto subscribe to Redux app settings stateprops.appSettings["urlPropsIgnore"])configuredAppSettings["urlPropsIgnore"]) toupdateUrl()andgetEffectiveUrlPropsIgnoreis re-evaluated when appdef settings land in Redux statetest/containers/app.spec.ts(new)getEffectiveUrlPropsIgnorecovering merging, trimming, empty filtering, and undefined inputsUsage
In an appdef
ViewerSettings(no HTML template change needed):Appdef-provided values are merged with any
urlPropsIgnoreprop already specified at mount time, so the two approaches compose rather than conflict.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
storybook.js.org/opt/hostedtoolcache/node/24.14.0/x64/bin/node /opt/hostedtoolcache/node/24.14.0/x64/bin/node /home/REDACTED/work/mapguide-react-layout/mapguide-react-layout/node_modules/.bin/storybook build -c .storybook(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.