chore: use charmcraft 3 #84
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyworld
force-pushed
the
use-charmcraft-3
branch
from
19744cf to
0c3a32a
Compare
We can only currently build for one base, but we can remote build on launchpad and thus get builds for all supported arches.
wallyworld
force-pushed
the
use-charmcraft-3
branch
from
0c3a32a to
c257e17
Compare
Member
|
Can you change this to a draft while it's in a fluid state? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can only currently build for one base, but we can remote build on launchpad and thus get builds for all supported arches.
To publish the charm, we need to manually update the manifest to add support for 20.04 and 22.04, until a decision is made about supporting multiple bases. Or we may need to manage separate charmcraft.yaml files.
The manual steps to do this were as follows:
charmcraft remote-build --launchpad-accept-public-uploadThis will run builds on lp for the 4 supported arches and the end result is 4 charm files downloaded locally.
Unzip these charm files and edit the
manifest.yamlto add support for both22.04and20.04. Rezip the charm files.Then the charms can be uploaded to charmhub:
charmcraft upload --name juju-controller --release 3.6/stable <charmfilename>TODO - need to replace the Build Charms code with charmcraft remote-build