feat: loki integration#118
Open
SimonRichardson wants to merge 12 commits into
Open
Conversation
This will ensure that the relation can integrate with other charms.
Ensure we call adding and removing s3 credentials when a relation is added or removed.
Using the event reveals all the information required, no need to ask for the information from somewhere else.
Uses loki integration to push the loki endpoint to juju database, so it can send all the information to all the agents. This will allow the a much more distributed logging approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #107 to land first. Although, this isn't explicitly tied to s3 integration, it does build upon some of the charm logic within it.
Uses the loki_push_api requirer integration to send the loki push URL to the controller charm. Once it has that, it will be up to the controller to distribute the loki endpoint to all agents, so that we can send logging to loki, instead of jujud-controller. This should elevate a lot of load in busy controllers.