fix(usedirect): update ReserveCalifornia booking URLs to modern routing#407
Conversation
ReserveCalifornia changed its website routing, moving away from the legacy format to a standard path-based structure. - Incorrect URL: https://www.reservecalifornia.com/Web/Default.aspx#!park/690/611 - Correct URL: https://www.reservecalifornia.com/park/690/611 This change introduces an overridable `get_booking_url()` method to the UseDirect base class, allowing ReserveCalifornia to safely define its modern URL structure without breaking older routing schemes still used by other states like Florida and Ohio. Test assertions have been updated accordingly.
|
Re-triggering CI — closing and reopening |
jufty-bot
left a comment
jufty-bot
left a comment
There was a problem hiding this comment.
Review: jufty-bot 🤖
URL Verification
Verified both old and new URL formats against ReserveCalifornia:
- Old format (
/Web/Default.aspx#!park/690/611): Returns SPA shell ✅ - New format (
/park/690/611): Returns same SPA shell ✅ (no 404)
The new path-based URLs align with the migration from hash-based SPA routing (#!...) to browser history API routing — standard React Router behavior. Both resolve to the same application entry point.
Code Quality
- Clean abstraction with
get_booking_url()on the base class — other UseDirect providers (Florida, Ohio, etc.) are unaffected - ReserveCalifornia override is minimal and focused
- Test assertions updated correctly
- 21 additions / 5 deletions across 4 files — low risk
CI
Triggered and running: lint, docker, and full Python 3.9–3.14 test matrix.
Looks good to merge once CI passes! 🦀
jufty-bot
left a comment
jufty-bot
left a comment
There was a problem hiding this comment.
CI Fixes Applied ✅
@juftin pushed two fixes to the branch:
- Ruff format —
camply/providers/usedirect/usedirect.pyreformatted - VCR cassette —
test_search_once_pushover.yamlcassette re-recorded with new/park/URL format
CI is re-running now with both fixes. 🦀
jufty-bot
left a comment
jufty-bot
left a comment
There was a problem hiding this comment.
Update: CI Fixes Applied 🛠️
@juftin pushed two fixes to the fix-reserve-california-url branch:
- ✅ ruff format —
camply/providers/usedirect/usedirect.pyreformatted - ✅ VCR cassette — Pushover test cassette re-recorded with new
/park/URL
All 108 tests now pass on every Python version (3.9–3.14). The only remaining "failure" is the coverage comment step on the fork, which PR #411 addresses separately.
Ready to merge when you are! 🦀
jufty-bot
left a comment
jufty-bot
left a comment
There was a problem hiding this comment.
Re-approved ✅
Both fixes applied, all 108 tests passing. This one is ready to go! 🦀
|
Thanks for your patience while I figure out how to get these agents to work for me. Good bot @jufty-bot! Thank you for the fix @kkweon! |
# [v0.34.2](v0.34.1...v0.34.2) (2026-05-24) ## 🐛 Bug Fixes - [`352ed0f`](352ed0f) update ReserveCalifornia booking URLs to modern routing (#407) (Issues: [`#407`](#407)) [skip ci]
|
🎉 This PR is included in version 0.34.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
3 participants
ReserveCalifornia changed its website routing, moving away from the legacy format to a standard path-based structure.
This change introduces an overridable
get_booking_url()method to the UseDirect base class, allowing ReserveCalifornia to safely define its modern URL structure without breaking older routing schemes still used by other states like Florida and Ohio. Test assertions have been updated accordingly.