Open
Conversation
mcpotter
reviewed
Nov 15, 2016
| private Boolean skipUi; | ||
|
|
||
| Alarm() { | ||
| this.daysToRepeat = new ArrayList<>(7); |
There was a problem hiding this comment.
Could just initialise this up in the list of fields? Or when they first go to add a day to repeat the alarm on maybe?
| */ | ||
| @NonNull | ||
| @CheckResult | ||
| public Calendar eventEndTime(@NonNull java.util.Calendar calendar) { |
There was a problem hiding this comment.
fully qualified names make me miss kotlin, lol.
| */ | ||
| @NonNull | ||
| @CheckResult | ||
| public Map latitude(@NonNull Double latitude) { |
There was a problem hiding this comment.
situations like here I think using the boxed value is fine because we need the user to specify both the latitude and longitude.
mcpotter
reviewed
Nov 15, 2016
| */ | ||
| @NonNull | ||
| @CheckResult | ||
| public Alarm silenceRingTone(@NonNull Boolean silenceRingTone) { |
There was a problem hiding this comment.
if you change this to accept a primitive instead you don't need to do the null check and you get the same result. Maybe we should have a discussion about whether we want to take primitives instead of boxed values whenever possible? What do you think, @AngusMorton?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Alarm, Timer, Calendar and Map to Shelly.
All classes include documentation.
More features could be added to Map
PTAL @AngusMorton @mcpotter