I resolved the bug when starting the AussieWeatherRadar without connectivity.#1
Open
njaffo wants to merge 2 commits intojtribe:masterfrom
Open
I resolved the bug when starting the AussieWeatherRadar without connectivity.#1njaffo wants to merge 2 commits intojtribe:masterfrom
njaffo wants to merge 2 commits intojtribe:masterfrom
Conversation
Now displays a "Not Connected" string when started with no connectivity. Possible future feature would be a manual refresh which clears the cache and pulls down fresh images. Curgently when connectivity restored it doesn't automatically pull down the maps, but if the user changes the pin or map size then the images are pulled down, except for the back map isn't pulled until the user clears the cache.
It was misleading to the user to have the progress animation showing when not connected, it gave the impression the app would resolve itself without user interaction when connectivity was restored. Deleting the cache when connectivity is not available on startup prevents the "blank" map persisting in the cache.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now displays a "Not Connected" string when started with no connectivity.
Possible future feature would be a manual refresh which clears the
cache and pulls down fresh images.
Curgently when connectivity restored it doesn't automatically pull down
the maps, but if the user changes the pin or map size then the images
are pulled down, except for the back map isn't pulled until the user
clears the cache.