feat(theme): Initial theme toggle functionality#36
Draft
websterbontilao wants to merge 5 commits intomainfrom
Draft
feat(theme): Initial theme toggle functionality#36websterbontilao wants to merge 5 commits intomainfrom
websterbontilao wants to merge 5 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
websterbontilao
commented
Sep 26, 2023
Collaborator
Author
There was a problem hiding this comment.
To be removed, since we'll utilize mapbox theming instead of open street map
ivanaposdev
reviewed
Sep 26, 2023
Comment on lines
+8
to
+13
| <ThemeContextProvider> | ||
| <AppContextProvider> | ||
| <Wrapper /> | ||
| <Drawer /> | ||
| </AppContextProvider> | ||
| </ThemeContextProvider> |
Member
There was a problem hiding this comment.
Please place the logic for switching themes in AppContextProvider instead of creating a new context provider ThemeContextProvider
Suggested change
| <ThemeContextProvider> | |
| <AppContextProvider> | |
| <Wrapper /> | |
| <Drawer /> | |
| </AppContextProvider> | |
| </ThemeContextProvider> | |
| <AppContextProvider> | |
| <ThemeProvider theme={/* insert theme value from app context here */} > | |
| <Wrapper /> | |
| <Drawer /> | |
| </ThemeProvider> | |
| </AppContextProvider> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Related issues
Fixes #___
Checklist