fix (service): add respect for fallback language for translateObject#583
Open
jensweigele wants to merge 1 commit intojsverse:masterfrom
Open
fix (service): add respect for fallback language for translateObject#583jensweigele wants to merge 1 commit intojsverse:masterfrom
jensweigele wants to merge 1 commit intojsverse:masterfrom
Conversation
Contributor
Author
|
This PR fixes #519 |
|
Really hate to tag people but @shaharkazaz could someone look into merging this? Seems like @jensweigele has done a great job at making this a small change. Really need the fallback language feature to work for our project setup. |
c068fa2 to
d2ade9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
selectTranslateObject and translateObject are not falling back to the fallback language.
Issue Number: N/A
What is the new behavior?
If the result object is empty, the translateObject is called with the fallback language.
Does this PR introduce a breaking change?
Other information