Skip to content
This repository was archived by the owner on Apr 1, 2025. It is now read-only.

Updated Readme.MD to fix a specific issue #89

Open
SelfDevTV wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updated Readme.MD to fix a specific issue #89

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,14 @@ var ActiveDirectory = require('activedirectory2');
var config = { url: 'ldap://dc.domain.com',
Copy link
Owner

@jsumners jsumners Nov 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change, I'd go ahead and change the whole block to look like:

var config = {
  url: 'foo',
  user: [
    // comment
    'dn'
  ]
}

The current reduced format become illegible with the inlined comments.

baseDN: 'dc=domain,dc=com',
username: 'username@domain.com',
password: 'password' }
password: 'password',
attributes: {
user: [
// your preferred attributes,
"dn"],
group: [
// your preferred attributes,
"dn"]}
var ad = new ActiveDirectory(config);
```

Expand Down