Open
Conversation
* ColorNumberConverter.cs: * ColorPicker.cs: * ColorPicker.xaml: [feature] Ändern der Farben über Textfelder
* ColorPicker.xaml: * RoundEffect.cs: * RoundEffect.cs: * ColorPicker.cs: * RadialPicker.cs: * ColorPickerGallery.xaml: * GradientLayout.cs: * RoundEffect.cs: * TemplateUI.Gallery.iOS.csproj: * RadialPickerRenderer.cs: * GradientLayoutRenderer.cs: * TemplateUI.Gallery.Android.csproj: * GradientLayoutRenderer.cs: * OpacityGradientLayoutRenderer.cs: * CornerRadiusOutlineProvider.cs: * OpacityGradientLayoutRenderer.cs: * ColorNumberHelper.cs: [feature] radial color picker [work in progress]
[feature] Luminosity thumb changes
Owner
|
@nguyenhAtMsg Awesome, will review it! |
jsuarezruiz
requested changes
Feb 21, 2021
Owner
jsuarezruiz
left a comment
jsuarezruiz
left a comment
There was a problem hiding this comment.
This is a fantastic job. With a few changes I think we can add a great new control. Let me know if I can help you with something.
| // @author: https://stackoverflow.com/users/9654227/na2axl | ||
| namespace TemplateUI.Gallery.Droid.Renderers | ||
| { | ||
| public class GradientLayoutRenderer : VisualElementRenderer<AbsoluteLayout> |
Owner
There was a problem hiding this comment.
Do we need this rendererer? Using Xamarin.Forms Brushes we would also support other platforms such as macOS.
| int endX; | ||
| int endY; | ||
|
|
||
| switch (this.gradientLayout.Mode) |
Owner
There was a problem hiding this comment.
In case we need this, we could move this code to extension methods. Pass a Color collection and return the LinearGradient to draw.
| <Reference Include="System.Xml" /> | ||
| <Reference Include="System.Numerics" /> | ||
| <Reference Include="System.Numerics.Vectors" /> | ||
| <Reference Include="Xamarin.iOS"> |
Owner
There was a problem hiding this comment.
Xamarin.iOS reference in the Android sample?
| * LAYER 1: MaskLayer | ||
| * LAYER 2: GradientLayer | ||
| */ | ||
| if (NativeView.Layer.Sublayers.Length == 1) |
Owner
There was a problem hiding this comment.
The Sublayers could be null at this point.
| new GalleryItem { Title = "ChatBubble", SubTitle = "Allow to show a speech bubble message.", Icon = "chatbubble.png", Color = Color.DarkSeaGreen }, | ||
| new GalleryItem { Title = "CircularLayout", SubTitle = "Is a simple Layout derivative that lays out its children in a circular arrangement.", Icon = "circularlayout.png", Color = Color.BlueViolet }, | ||
| //new GalleryItem { Title = "CircleProgressBar", SubTitle = "Shows a control that indicates the progress percentage of an on-going operation by circular shape.", Icon = "circleprogressbar.png", Color = Color.LightGray, Status = GalleryItemStatus.InProgress }, | ||
| new GalleryItem { Title = "ColorPicker", SubTitle = "Picker for choosing Color.", Icon = "circularlayout.png", Color = Color.Red}, |
Owner
There was a problem hiding this comment.
Could we include a new specific icon?
| <ContentPage | ||
| Title="Avatar Size" | ||
| IconImageSource="customize.png"> | ||
| <!--<ContentPage.Content> |
Owner
There was a problem hiding this comment.
This tabs do not seem necessary, better remove to avoid confusions.
| @@ -0,0 +1,180 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
Owner
There was a problem hiding this comment.
There are some binding issues in the Template:
Binding: 'B' property not found on '[Color: A=1, R=0.104443669319153, G=0.408039718866348, B=0.65434455871582, Hue=0.574651300907135, Saturation=0.724709272384644, Luminosity=0.379394114017487]', target property: 'Xamarin.Forms.Entry.Text'
Binding: 'G' property not found on '[Color: A=1, R=0.105486810207367, G=0.405179709196091, B=0.648317933082581, Hue=0.574651300907135, Saturation=0.720121681690216, Luminosity=0.376902371644974]', target property: 'Xamarin.Forms.Entry.Text'
Binding: 'B' property not found on '[Color: A=1, R=0.105486810207367, G=0.405179709196091, B=0.648317933082581, Hue=0.574651300907135, Saturation=0.720121681690216, Luminosity=0.376902371644974]', target property: 'Xamarin.Forms.Entry.Text'
Binding: 'G' property not found on '[Color: A=1, R=0.105543076992035, G=0.400331497192383, B=0.639490783214569, Hue=0.574651300907135, Saturation=0.716675817966461, Luminosity=0.372516930103302]', target property: 'Xamarin.Forms.Entry.Text'
Binding: 'B' property not found on '[Color: A=1, R=0.105543076992035, G=0.400331497192383, B=0.639490783214569, Hue=0.574651300907135, Saturation=0.716675817966461, Luminosity=0.372516930103302]', target property: 'Xamarin.Forms.Entry.Text'
Binding: 'Luminosity' property not found on '[Color: A=1, R=0.105543076992035, G=0.400331497192383, B=0.639490783214569, Hue=0.574651300907135, Saturation=0.716675817966461, Luminosity=0.372516930103302]', target property: 'Xamarin.Forms.Entry.Text'
Binding: 'Saturation' property not found on '[Color: A=1, R=0.106933355331421, G=0.401164650917053, B=0.639871954917908, Hue=0.574651300907135, Saturation=0.713624477386475, Luminosity=0.373402655124664]', target property: 'Xamarin.Forms.Entry.Text'
Binding: 'G' property not found on '[Color: A=1, R=0.105764865875244, G=0.396856516599655, B=0.633016645908356, Hue=0.574651300907135, Saturation=0.713677525520325, Luminosity=0.3693907558918]', target property: 'Xamarin.Forms.Entry.Text'
Binding: 'B' property not found on '[Color: A=1, R=0.105764865875244, G=0.396856516599655, B=0.633016645908356, Hue=0.574651300907135, Saturation=0.713677525520325, Luminosity=0.3693907558918]', target property: 'Xamarin.Forms.Entry.Text'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[WORK IN PROGRESS!]
Hello Javier,
This is my first feature in Xamarin and it's still in progress. I create the pull request in order to get feedback from others to improve.
Thanks in Advance.