Skip to content

Conversation

@Galaxy102
Copy link

Hello,

for non-US fellas using Letter as paper format is pretty uncommon. Thus I thought it would be great if you could pass the PDF paper size as an option.

Please let me know about anything improvable, Javascript is not my main programming language.

Cheers!

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (5)

lib/export-resume.js:11

  • [nitpick] The parameter name 'papersize' should be renamed to 'paperSize' to follow camelCase convention.
{ resume: resumeJson, fileName, theme, format, papersize },

lib/export-resume.js:31

  • [nitpick] The parameter name 'papersize' should be renamed to 'paperSize' to follow camelCase convention.
createPdf(resumeJson, fileName, theme, formatToUse, papersize, (error) => {

lib/export-resume.js:84

  • [nitpick] The parameter name 'papersize' should be renamed to 'paperSize' to follow camelCase convention.
papersize,

lib/export-resume.js:117

  • [nitpick] The parameter name 'papersize' should be renamed to 'paperSize' to follow camelCase convention.
format: papersize,

lib/export-resume.js:11

  • Ensure that the new 'papersize' option is covered by tests to verify it works as expected.
{ resume: resumeJson, fileName, theme, format, papersize },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant