docs(README.md): added example Dockerfile and instructions to run inside docker#598
Closed
beaverden wants to merge 1 commit intojsonresume:masterfrom
Closed
docs(README.md): added example Dockerfile and instructions to run inside docker#598beaverden wants to merge 1 commit intojsonresume:masterfrom
beaverden wants to merge 1 commit intojsonresume:masterfrom
Conversation
…library inside docker
Author
|
It seems like there already are docker images for jsonresume (like https://hub.docker.com/r/svendowideit/jsonresume/ - https://github.com/SvenDowideit/dockerfiles/blob/master/jsonresume/Dockerfile) Which do a much better job at being able to run generic commands |
Member
|
@beaverden Thanks for that, are you saying the pre-existing docker setups solve your initial problem? |
Author
|
I realized that the purpose of the fix was to specify how to run the library when chromium doesn't install properly using puppeteer and npm, not to add a (somehow) working dockerfile (of which there already are plenty). See #599 for a lighter fix that just adds some info to the README |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I submitted the first draft of running the library though docker, although I'm not sure if it's the right way. Technically, the library is not dockerized and it's just a container that installs the library through
npm.Probably a better solution would be to dockerize the library itself and provide the image on docker hub, such that different commands can be ran. With that being said, I can't say that I'm experienced in dockerizing npm packages