Skip to content
This repository was archived by the owner on Jan 10, 2020. It is now read-only.

Conversation

@ahill00
Copy link

@ahill00 ahill00 commented Apr 3, 2012

This pull request adds in a learn by url plugin which is activated by markov learn_url

@Oblomov
Copy link
Collaborator

Oblomov commented Apr 25, 2013

While I like the concept, the patch has a few issues as-is.

First of all, rather than using a separate command-line instruction I would rather prefer "markov learn from " be used. learn_from() would thus check if the parameter is an url or a filename and act accordingly.

Also, the dependency from w3m is not an approach I like. A better approach would be to get the page content using rbot's own httputil functions to get the text, clean it up using the rbot methods such as ircify_html or riphtml, and then iterate of the lines with .each_line.

The code could actually remain in the same block, just name the source source and iterate wtih source.each_line where source = file in the file path and source = cleaned_text in the url case.

dgadling and others added 2 commits September 16, 2013 19:43
Acrophobia for IRC. More information on acrophobia is available
on wikipedia. Includes a Hall of Fame (scoreboard).
Unfortunately doesn't work on a per-channel basis since some
secrecy is required.

Signed-off-by: Andy Hill <hillad@gmail.com>
ammaraskar pushed a commit to ammaraskar/rbot that referenced this pull request Nov 25, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants