Open
Conversation
bjohansebas
approved these changes
Feb 14, 2026
sheplu
requested changes
Feb 15, 2026
Member
sheplu
left a comment
There was a problem hiding this comment.
Just a change for the folder that should host the two new bench files
Other than than LGTM!
| @@ -0,0 +1,41 @@ | |||
| import { describe, bench } from "vitest"; | |||
Member
There was a problem hiding this comment.
would that make more sense to move the two new bench.ts file in the benchmark folder already existing?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I decided to try investigating if anything in #250 holds true, and found the opposite for string concatenation. Updated to use string concatenation to improve performance.
Before:
After: