Sync Claude ACP vendor to 0.39.0#175
Open
jsgrrchg wants to merge 2 commits into
Open
Conversation
Owner
Author
|
agentclientprotocol/claude-agent-acp#729 Upstream PR fixing this issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vendor/Claude-agent-acp-upstreamto upstream@agentclientprotocol/claude-agent-acpv0.39.0.dist/runtime files from the updated source snapshot.Security note
The GitHub Advanced Security / CodeQL warning was inherited from upstream
@agentclientprotocol/claude-agent-acpv0.39.0. It was not introduced by NeverWrite changes.Upstream
v0.39.0replaced the previous scanner with a regex for stripping local-command metadata. CodeQL flags that regex as potentially polynomial on uncontrolled input. This PR restores an equivalent linear scanner and adds regression coverage for unterminated and marker-like repeated input.Impact
This brings the embedded Claude ACP runtime onto the upstream release that includes Claude Agent SDK
0.3.156, while avoiding the upstream regex pattern that triggered the security alert. The runtime staged for Electron was refreshed after the fix.Validation
npm installinvendor/Claude-agent-acp-upstreamnpm run buildinvendor/Claude-agent-acp-upstreamnpm run test:runinvendor/Claude-agent-acp-upstream— 301 passed, 13 skippednpm run checkinvendor/Claude-agent-acp-upstreamgit diff --checksrc, generateddist, and the staged Electron runtimenpm run electron:sidecar:stage -- --skip-buildand verified the staged Claude ACP is0.39.0with SDK0.3.156