Skip to content

Conversation

@codedust
Copy link
Contributor

@codedust codedust commented Apr 6, 2025

Fix bug introduced in 24efe89

see #76

@github-actions
Copy link

github-actions bot commented Apr 6, 2025

Performance impact

Impact on 9 metrics when merging patch-1 into main. Before drawing conclusion, keep in mind performance variability.

package metrics (-0.2%)
Metric Before merge After merge Impact
import duration 0.2 second 0.2 second -0.002 second / -1% ↘️
import memory heap used 8.9 MB 8.9 MB +432 B / +0.005% ↗️
npm tarball size 26.2 kB 26.2 kB -1 B / -0.004% ↘️
npm tarball unpacked size 115 kB 115 kB 👻
npm tarball file count 23 23 👻
write importmap metrics (-0.3%)
Metric Before merge After merge Impact
write importmap duration 0.2 second 0.2 second -0.002 second / -1% ↘️
write importmap memory heap used 9 MB 9 MB +1.1 kB / +0.01% ↗️
number of fs read operation 0 0 👻
number of fs write operation 8 8 👻
Generated by @jsenv/performance-impact during performance_impact#14290366761 on cdc8a55

@dmail
Copy link
Member

dmail commented Apr 6, 2025

I should add unit test to the cli 😅
can you bump the version in the package.json?
This way when I'll merge this pr it will publish this version to npm

@dmail dmail merged commit 69bbd8a into jsenv:main Apr 13, 2025
5 checks passed
@dmail
Copy link
Member

dmail commented Apr 13, 2025

Will be published by 00c8761

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants