Various modernizations

.github/workflows/build.yml

@@ -1,9 +1,13 @@
 name: Build
+
 on:
   pull_request:
-    branches: [main]
+    branches:
+    - main
   push:
-    branches: [main]
+    branches:
+    - main
+
 jobs:
   build:
     name: Lint and tests
@@ -14,6 +18,7 @@ jobs:
         node-version:
           - 20
           - 22
+          - 24
           - latest
     steps:
     - uses: actions/checkout@v6

.github/workflows/publish.yml

@@ -0,0 +1,24 @@
+name: Publish
+
+on:
+  push:
+    tags:
+      - 'v*'
+
+permissions:
+  id-token: write
+  contents: read
+
+jobs:
+  publish:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v6
+      - uses: actions/setup-node@v6
+        with:
+          node-version: lts/*
+          registry-url: https://registry.npmjs.org
+      - run: npm ci
+      - run: npm run lint
+      - run: npm test
+      - run: npm publish

eslint.config.mjs

@@ -9,13 +9,12 @@ export default [
       globals: globals.node
     }
   },
-  ...domenicConfig,
   {
-    files: ["scripts/**.js"],
-    rules: {
-      "no-process-env": "off",
-      "no-process-exit": "off",
-      "no-console": "off"
+    files: ["**/*.mjs"],
+    languageOptions: {
+      sourceType: "module",
+      globals: globals.node
     }
-  }
+  },
+  ...domenicConfig
 ];

lib/parser.js

@@ -1,5 +1,5 @@
 "use strict";
-const MIMEType = require("whatwg-mimetype");
+const { MIMEType } = require("whatwg-mimetype");
 const { parseURL, serializeURL, percentDecodeString } = require("whatwg-url");
 const { stripLeadingAndTrailingASCIIWhitespace, isomorphicDecode, forgivingBase64Decode } = require("./utils.js");
 

package.json

@@ -23,11 +23,11 @@
   "scripts": {
     "test": "node --test",
     "coverage": "c8 node --test --experimental-test-coverage",
-    "lint": "eslint .",
-    "pretest": "node scripts/get-latest-platform-tests.js"
+    "lint": "eslint",
+    "pretest": "node scripts/get-latest-platform-tests.mjs"
   },
   "dependencies": {
-    "whatwg-mimetype": "^4.0.0",
+    "whatwg-mimetype": "^5.0.0",
     "whatwg-url": "^15.1.0"
   },
   "devDependencies": {
@@ -41,7 +41,6 @@
   },
   "c8": {
     "reporter": [
-      "text",
       "html"
     ],
     "exclude": [

scripts/get-latest-platform-tests.js → scripts/get-latest-platform-tests.mjs

@@ -1,36 +1,27 @@
-"use strict";
+import * as path from "node:path";
+import * as fs from "node:fs/promises";
 
 if (process.env.NO_UPDATE) {
   process.exit(0);
 }
 
-const path = require("node:path");
-const fs = require("node:fs/promises");
-
 // Pin to specific version, reflecting the spec version in the readme.
 //
 // To get the latest commit:
 // 1. Go to https://github.com/web-platform-tests/wpt/tree/master/fetch/data-urls
 // 2. Press "y" on your keyboard to get a permalink
 // 3. Copy the commit hash
-const commitHash = "d9d78543960a04ea8ad8f1aa3c7536b6a9a87d9a";
+const commitHash = "2dc0ad4f330f0b5647d11b00ae7437b668cb8df3";
 
 const urlPrefix = `https://raw.githubusercontent.com/w3c/web-platform-tests/${commitHash}` +
                   `/fetch/data-urls/resources/`;
 
 const files = ["base64.json", "data-urls.json"];
 
-async function main() {
-  await Promise.all(files.map(async file => {
-    const url = urlPrefix + file;
-    const targetFile = path.resolve(__dirname, "..", "test", "web-platform-tests", file);
-
-    const res = await fetch(url);
-    await fs.writeFile(targetFile, res.body);
-  }));
-}
+await Promise.all(files.map(async file => {
+  const url = urlPrefix + file;
+  const targetFile = path.resolve(import.meta.dirname, "..", "test", "web-platform-tests", file);
 
-main().catch(e => {
-  console.error(e.stack);
-  process.exit(1);
-});
+  const res = await fetch(url);
+  await fs.writeFile(targetFile, res.body);
+}));

test/api.js

@@ -1,6 +1,6 @@
 "use strict";
 const { describe, it } = require("node:test");
-const assert = require("node:assert");
+const assert = require("node:assert/strict");
 const parseDataURL = require("..");
 /*
   eslint

test/web-platform.js

@@ -1,15 +1,15 @@
 "use strict";
 const { describe, test } = require("node:test");
-const assert = require("node:assert");
+const assert = require("node:assert/strict");
 const base64TestCases = require("./web-platform-tests/base64.json");
 const dataURLsTestCases = require("./web-platform-tests/data-urls.json");
-const parse = require("../lib/parser.js");
+const parseDataURL = require("..");
 
 describe("base64.json", () => {
   for (const [input, expectedBodyBytes] of base64TestCases) {
     const dataURL = `data:;base64,${input}`;
     test(dataURL, () => {
-      const result = parse(dataURL);
+      const result = parseDataURL(dataURL);
 
       if (expectedBodyBytes === null) {
         assert.equal(result, null);
@@ -29,7 +29,7 @@ describe("base64.json", () => {
 describe("data-urls.json", () => {
   for (const [dataURL, expectedMIMEType, expectedBodyBytes] of dataURLsTestCases) {
     test(dataURL, () => {
-      const result = parse(dataURL);
+      const result = parseDataURL(dataURL);
 
       if (expectedMIMEType === null) {
         assert.equal(result, null);