feat: add support for choosing between Logical (1x) and Native (Retina) capture resolutions#134
Merged
jsattler merged 1 commit intojsattler:mainfrom Mar 18, 2026
Conversation
…a) capture resolutions
Owner
|
Hi @samandeep-singh thanks for your contribution. I'd like to keep the resolution setting in the advanced section only (not in the menu bar), since the menu bar is already growing quite large. What do you think? I'll take a closer look into rest of the changes asap. This will be a great improvement! |
Contributor
Author
|
Definitely, I think that will be better, I can remove it from the menu bar. Feel free to let me know any other changes you'd like me to make and I'll update the PR |
Owner
Code looks good, thanks! I'm going to do some smoke testing tomorrow and test that everything works. |
jsattler
added a commit
that referenced
this pull request
Mar 18, 2026
- Align default value pattern with existing codebase convention (as? Bool ?? true) - Remove unnecessary init() and registerDefaultSettings() from SettingsStore - Rename toggle label to 'Native Resolution' - Remove toggle from MenuBarSettingsView - Improve help text to clarify toggle behavior and non-Retina displays - Fix missing space in ternary expression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #125
Changelog
SettingsViewandMenuBarSettingsViewSettingsStoreto add a new UserDefault for captureNativeResolution and added a register function that sets the default value for the key to true. TheUserDefaults.standard.register()function sets the default value for the key if it doesn't already exist in User DefaultsRecorderViewModel.getContentSize()function to conditionally apply scale multiplicationScreenshots
Please let me know if the positioning of the toggle should be changed or any other modifications I should make, thanks!