Skip to content

feat: add settings to adjust bitrate/quality #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsattler merged 5 commits into from
Mar 14, 2026
Merged

feat: add settings to adjust bitrate/quality #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2f40904
feat: add settings to adjust bitrate/quality
jsattler Feb 17, 2026
a883f62
refactor: simplify quality setting detection
jsattler Mar 14, 2026
981ce6a
chore: tweak bitrate and fps settings
jsattler Mar 14, 2026
d3c1fb2
chore: set default quality to medium
jsattler Mar 14, 2026
0b0256b
fix: remove ui tests due to failing in gh action
jsattler Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions .github/workflows/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,25 +40,3 @@ jobs:
CODE_SIGNING_REQUIRED=NO \
| xcbeautify --renderer github-actions || true

test:
name: Test
runs-on: macos-26
timeout-minutes: 15

steps:
- name: Checkout repository
uses: actions/checkout@v4

- name: Select Xcode version
run: sudo xcode-select -s /Applications/Xcode_${{ env.XCODE_VERSION }}.app

- name: Run tests
run: |
xcodebuild test \
-project "${{ env.APP_NAME }}.xcodeproj" \
-scheme "${{ env.SCHEME }}" \
-configuration Debug \
-destination "platform=macOS" \
CODE_SIGN_IDENTITY="-" \
CODE_SIGNING_REQUIRED=NO \
| xcbeautify --renderer github-actions || true
242 changes: 1 addition & 241 deletions BetterCapture.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,27 +10,8 @@
6C5C123D2F3893FE0082CE23 /* Sparkle in Frameworks */ = {isa = PBXBuildFile; productRef = 6C0990E12F2BE0C200D48100 /* Sparkle */; };
/* End PBXBuildFile section */

/* Begin PBXContainerItemProxy section */
6C0990BD2F2BE0C200D48100 /* PBXContainerItemProxy */ = {
isa = PBXContainerItemProxy;
containerPortal = 6C0990A72F2BE0C100D48100 /* Project object */;
proxyType = 1;
remoteGlobalIDString = 6C0990AE2F2BE0C100D48100;
remoteInfo = BetterCapture;
};
6C0990C72F2BE0C200D48100 /* PBXContainerItemProxy */ = {
isa = PBXContainerItemProxy;
containerPortal = 6C0990A72F2BE0C100D48100 /* Project object */;
proxyType = 1;
remoteGlobalIDString = 6C0990AE2F2BE0C100D48100;
remoteInfo = BetterCapture;
};
/* End PBXContainerItemProxy section */

/* Begin PBXFileReference section */
6C0990AF2F2BE0C100D48100 /* BetterCapture.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = BetterCapture.app; sourceTree = BUILT_PRODUCTS_DIR; };
6C0990BC2F2BE0C200D48100 /* BetterCaptureTests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = BetterCaptureTests.xctest; sourceTree = BUILT_PRODUCTS_DIR; };
6C0990C62F2BE0C200D48100 /* BetterCaptureUITests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = BetterCaptureUITests.xctest; sourceTree = BUILT_PRODUCTS_DIR; };
/* End PBXFileReference section */

/* Begin PBXFileSystemSynchronizedBuildFileExceptionSet section */
Expand All @@ -52,16 +33,6 @@
path = BetterCapture;
sourceTree = "<group>";
};
6C0990BF2F2BE0C200D48100 /* BetterCaptureTests */ = {
isa = PBXFileSystemSynchronizedRootGroup;
path = BetterCaptureTests;
sourceTree = "<group>";
};
6C0990C92F2BE0C200D48100 /* BetterCaptureUITests */ = {
isa = PBXFileSystemSynchronizedRootGroup;
path = BetterCaptureUITests;
sourceTree = "<group>";
};
/* End PBXFileSystemSynchronizedRootGroup section */

/* Begin PBXFrameworksBuildPhase section */
Expand All @@ -73,29 +44,13 @@
);
runOnlyForDeploymentPostprocessing = 0;
};
6C0990B92F2BE0C200D48100 /* Frameworks */ = {
isa = PBXFrameworksBuildPhase;
buildActionMask = 2147483647;
files = (
);
runOnlyForDeploymentPostprocessing = 0;
};
6C0990C32F2BE0C200D48100 /* Frameworks */ = {
isa = PBXFrameworksBuildPhase;
buildActionMask = 2147483647;
files = (
);
runOnlyForDeploymentPostprocessing = 0;
};
/* End PBXFrameworksBuildPhase section */

/* Begin PBXGroup section */
6C0990A62F2BE0C100D48100 = {
isa = PBXGroup;
children = (
6C0990B12F2BE0C100D48100 /* BetterCapture */,
6C0990BF2F2BE0C200D48100 /* BetterCaptureTests */,
6C0990C92F2BE0C200D48100 /* BetterCaptureUITests */,
6C0990B02F2BE0C100D48100 /* Products */,
);
sourceTree = "<group>";
Expand All @@ -104,8 +59,6 @@
isa = PBXGroup;
children = (
6C0990AF2F2BE0C100D48100 /* BetterCapture.app */,
6C0990BC2F2BE0C200D48100 /* BetterCaptureTests.xctest */,
6C0990C62F2BE0C200D48100 /* BetterCaptureUITests.xctest */,
);
name = Products;
sourceTree = "<group>";
Expand Down Expand Up @@ -136,52 +89,6 @@
productReference = 6C0990AF2F2BE0C100D48100 /* BetterCapture.app */;
productType = "com.apple.product-type.application";
};
6C0990BB2F2BE0C200D48100 /* BetterCaptureTests */ = {
isa = PBXNativeTarget;
buildConfigurationList = 6C0990D32F2BE0C200D48100 /* Build configuration list for PBXNativeTarget "BetterCaptureTests" */;
buildPhases = (
6C0990B82F2BE0C200D48100 /* Sources */,
6C0990B92F2BE0C200D48100 /* Frameworks */,
6C0990BA2F2BE0C200D48100 /* Resources */,
);
buildRules = (
);
dependencies = (
6C0990BE2F2BE0C200D48100 /* PBXTargetDependency */,
);
fileSystemSynchronizedGroups = (
6C0990BF2F2BE0C200D48100 /* BetterCaptureTests */,
);
name = BetterCaptureTests;
packageProductDependencies = (
);
productName = BetterCaptureTests;
productReference = 6C0990BC2F2BE0C200D48100 /* BetterCaptureTests.xctest */;
productType = "com.apple.product-type.bundle.unit-test";
};
6C0990C52F2BE0C200D48100 /* BetterCaptureUITests */ = {
isa = PBXNativeTarget;
buildConfigurationList = 6C0990D62F2BE0C200D48100 /* Build configuration list for PBXNativeTarget "BetterCaptureUITests" */;
buildPhases = (
6C0990C22F2BE0C200D48100 /* Sources */,
6C0990C32F2BE0C200D48100 /* Frameworks */,
6C0990C42F2BE0C200D48100 /* Resources */,
);
buildRules = (
);
dependencies = (
6C0990C82F2BE0C200D48100 /* PBXTargetDependency */,
);
fileSystemSynchronizedGroups = (
6C0990C92F2BE0C200D48100 /* BetterCaptureUITests */,
);
name = BetterCaptureUITests;
packageProductDependencies = (
);
productName = BetterCaptureUITests;
productReference = 6C0990C62F2BE0C200D48100 /* BetterCaptureUITests.xctest */;
productType = "com.apple.product-type.bundle.ui-testing";
};
/* End PBXNativeTarget section */

/* Begin PBXProject section */
Expand All @@ -195,15 +102,7 @@
6C0990AE2F2BE0C100D48100 = {
CreatedOnToolsVersion = 26.0.1;
};
6C0990BB2F2BE0C200D48100 = {
CreatedOnToolsVersion = 26.0.1;
TestTargetID = 6C0990AE2F2BE0C100D48100;
};
6C0990C52F2BE0C200D48100 = {
CreatedOnToolsVersion = 26.0.1;
TestTargetID = 6C0990AE2F2BE0C100D48100;
};
};
};
buildConfigurationList = 6C0990AA2F2BE0C100D48100 /* Build configuration list for PBXProject "BetterCapture" */;
developmentRegion = en;
Expand All @@ -223,8 +122,6 @@
projectRoot = "";
targets = (
6C0990AE2F2BE0C100D48100 /* BetterCapture */,
6C0990BB2F2BE0C200D48100 /* BetterCaptureTests */,
6C0990C52F2BE0C200D48100 /* BetterCaptureUITests */,
);
};
/* End PBXProject section */
Expand All @@ -237,20 +134,6 @@
);
runOnlyForDeploymentPostprocessing = 0;
};
6C0990BA2F2BE0C200D48100 /* Resources */ = {
isa = PBXResourcesBuildPhase;
buildActionMask = 2147483647;
files = (
);
runOnlyForDeploymentPostprocessing = 0;
};
6C0990C42F2BE0C200D48100 /* Resources */ = {
isa = PBXResourcesBuildPhase;
buildActionMask = 2147483647;
files = (
);
runOnlyForDeploymentPostprocessing = 0;
};
/* End PBXResourcesBuildPhase section */

/* Begin PBXSourcesBuildPhase section */
Expand All @@ -261,34 +144,9 @@
);
runOnlyForDeploymentPostprocessing = 0;
};
6C0990B82F2BE0C200D48100 /* Sources */ = {
isa = PBXSourcesBuildPhase;
buildActionMask = 2147483647;
files = (
);
runOnlyForDeploymentPostprocessing = 0;
};
6C0990C22F2BE0C200D48100 /* Sources */ = {
isa = PBXSourcesBuildPhase;
buildActionMask = 2147483647;
files = (
);
runOnlyForDeploymentPostprocessing = 0;
};
/* End PBXSourcesBuildPhase section */

/* Begin PBXTargetDependency section */
6C0990BE2F2BE0C200D48100 /* PBXTargetDependency */ = {
isa = PBXTargetDependency;
target = 6C0990AE2F2BE0C100D48100 /* BetterCapture */;
targetProxy = 6C0990BD2F2BE0C200D48100 /* PBXContainerItemProxy */;
};
6C0990C82F2BE0C200D48100 /* PBXTargetDependency */ = {
isa = PBXTargetDependency;
target = 6C0990AE2F2BE0C100D48100 /* BetterCapture */;
targetProxy = 6C0990C72F2BE0C200D48100 /* PBXContainerItemProxy */;
};
/* End PBXTargetDependency section */


/* Begin XCBuildConfiguration section */
6C0990CE2F2BE0C200D48100 /* Debug */ = {
Expand Down Expand Up @@ -487,86 +345,6 @@
};
name = Release;
};
6C0990D42F2BE0C200D48100 /* Debug */ = {
isa = XCBuildConfiguration;
buildSettings = {
BUNDLE_LOADER = "$(TEST_HOST)";
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_TEAM = DMX24B5FC3;
GENERATE_INFOPLIST_FILE = YES;
MACOSX_DEPLOYMENT_TARGET = 15.0;
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = com.sattlerjoshua.BetterCaptureTests;
PRODUCT_NAME = "$(TARGET_NAME)";
STRING_CATALOG_GENERATE_SYMBOLS = NO;
SWIFT_APPROACHABLE_CONCURRENCY = YES;
SWIFT_EMIT_LOC_STRINGS = NO;
SWIFT_UPCOMING_FEATURE_MEMBER_IMPORT_VISIBILITY = YES;
SWIFT_VERSION = 5.0;
TEST_HOST = "$(BUILT_PRODUCTS_DIR)/BetterCapture.app/$(BUNDLE_EXECUTABLE_FOLDER_PATH)/BetterCapture";
};
name = Debug;
};
6C0990D52F2BE0C200D48100 /* Release */ = {
isa = XCBuildConfiguration;
buildSettings = {
BUNDLE_LOADER = "$(TEST_HOST)";
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_TEAM = DMX24B5FC3;
GENERATE_INFOPLIST_FILE = YES;
MACOSX_DEPLOYMENT_TARGET = 15.0;
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = com.sattlerjoshua.BetterCaptureTests;
PRODUCT_NAME = "$(TARGET_NAME)";
STRING_CATALOG_GENERATE_SYMBOLS = NO;
SWIFT_APPROACHABLE_CONCURRENCY = YES;
SWIFT_EMIT_LOC_STRINGS = NO;
SWIFT_UPCOMING_FEATURE_MEMBER_IMPORT_VISIBILITY = YES;
SWIFT_VERSION = 5.0;
TEST_HOST = "$(BUILT_PRODUCTS_DIR)/BetterCapture.app/$(BUNDLE_EXECUTABLE_FOLDER_PATH)/BetterCapture";
};
name = Release;
};
6C0990D72F2BE0C200D48100 /* Debug */ = {
isa = XCBuildConfiguration;
buildSettings = {
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_TEAM = DMX24B5FC3;
GENERATE_INFOPLIST_FILE = YES;
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = com.sattlerjoshua.BetterCaptureUITests;
PRODUCT_NAME = "$(TARGET_NAME)";
STRING_CATALOG_GENERATE_SYMBOLS = NO;
SWIFT_APPROACHABLE_CONCURRENCY = YES;
SWIFT_EMIT_LOC_STRINGS = NO;
SWIFT_UPCOMING_FEATURE_MEMBER_IMPORT_VISIBILITY = YES;
SWIFT_VERSION = 5.0;
TEST_TARGET_NAME = BetterCapture;
};
name = Debug;
};
6C0990D82F2BE0C200D48100 /* Release */ = {
isa = XCBuildConfiguration;
buildSettings = {
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_TEAM = DMX24B5FC3;
GENERATE_INFOPLIST_FILE = YES;
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = com.sattlerjoshua.BetterCaptureUITests;
PRODUCT_NAME = "$(TARGET_NAME)";
STRING_CATALOG_GENERATE_SYMBOLS = NO;
SWIFT_APPROACHABLE_CONCURRENCY = YES;
SWIFT_EMIT_LOC_STRINGS = NO;
SWIFT_UPCOMING_FEATURE_MEMBER_IMPORT_VISIBILITY = YES;
SWIFT_VERSION = 5.0;
TEST_TARGET_NAME = BetterCapture;
};
name = Release;
};
/* End XCBuildConfiguration section */

/* Begin XCConfigurationList section */
Expand All @@ -588,24 +366,6 @@
defaultConfigurationIsVisible = 0;
defaultConfigurationName = Release;
};
6C0990D32F2BE0C200D48100 /* Build configuration list for PBXNativeTarget "BetterCaptureTests" */ = {
isa = XCConfigurationList;
buildConfigurations = (
6C0990D42F2BE0C200D48100 /* Debug */,
6C0990D52F2BE0C200D48100 /* Release */,
);
defaultConfigurationIsVisible = 0;
defaultConfigurationName = Release;
};
6C0990D62F2BE0C200D48100 /* Build configuration list for PBXNativeTarget "BetterCaptureUITests" */ = {
isa = XCConfigurationList;
buildConfigurations = (
6C0990D72F2BE0C200D48100 /* Debug */,
6C0990D82F2BE0C200D48100 /* Release */,
);
defaultConfigurationIsVisible = 0;
defaultConfigurationName = Release;
};
/* End XCConfigurationList section */

/* Begin XCRemoteSwiftPackageReference section */
Expand Down
Loading
Loading