Merge TransactionPropagationIT into TransactionalMethodIT#121
Open
Ayushman-Gaur wants to merge 1 commit into
Open
Merge TransactionPropagationIT into TransactionalMethodIT#121Ayushman-Gaur wants to merge 1 commit into
Ayushman-Gaur wants to merge 1 commit into
Conversation
Signed-off-by: Ayushman Gaur <ayushmangaur2017@gmail.com>
cl90
requested changes
Mar 10, 2026
| SimpleClassWithTransactionalMethod.class, CallingSubClassOfSimpleClassWithTransactionalMethod.class, | ||
| GenericTransactionalClass.class, CallingSubClassOfGenericTransactionalClass.class, | ||
| GenericClassWithTransactionalMethod.class, CallingSubClassOfGenericClassWithTransactionalMethod.class); | ||
| assertThat(applyConcept("spring-transaction:TransactionalMethod").getStatus()).isEqualTo(SUCCESS); |
There was a problem hiding this comment.
Thank you very much for your contribution.
Please modify this test so it verifies the result of applyConcept as well. The result should contain the (declaring) type, the transactionalMethod and the transactionPropagation.
You can you can you use these tests as a reference how to handle conceptResults: https://github.com/jqassistant-plugin/jqassistant-jee-plugin/blob/main/src/test/java/org/jqassistant/plugin/jee/transaction/concept/TransactionPropagationIT.java
The tests that you have correctly moved here only cover some special cases.
The main branch has changed in the meantime, so I recommend rebasing you branch first 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #120
Changes
propagationOnTypeAndMethodLevelandpropagationOnMethodLeveltest methods from
TransactionPropagationITintoTransactionalMethodITTransactionalMethodITTransactionPropagationITas it no longer contains any unique test coverageTesting
All tests pass successfully (exit code 0)