SPM: Explicit declarations for external dependencies

[ailinykh]

When I tried to build my project using Xcode 16, I got an error:

error: 'sourcekitten': dependency 'Yams' in target 'SourceKittenFramework' requires explicit declaration; reference the package in the target dependency with '.product(name: "Yams", package: "yams")'
make: *** [build] Error 1

[johnfairh]

I don't mind taking this change; that said, do you understand what is different about your environment/project settings that's triggering this?

[ailinykh]

Here is what my setup looks like:

graph TD;
    MyProject-->MyPrivateProject;
    MyPrivateProject-->Yams;
    SourceKitten-->Yams;
    MyProject-->SourceKitten;

Loading

so I suppose that SPM can't make a decision what Yams to use when it comes to build SourceKittenFramework. Should it checkout a new one, or it could rely to MyPrivateProject's dependency

SourceKitten is 0.37.0
Yams is 5.3.1 (in both cases)

[ailinykh]

I made more precise research and what I've found:

1. Error message comes from ModulesGraph.swift
2. The productDependencyMissingPackage error thrown from ModulesGraph+Loading.swift
3. The comment above says:

// Starting in 5.2, and module-based dependency, we require module product dependencies to
// explicitly reference the package containing the product, or for the product, package and
// dependency to share the same name. We don't check this in manifest loading for root-packages so
// we can provide a more detailed diagnostic here.

Therefore I suspect that the root cause is target name Yams matches the package name Yams and SPM can't resolve it

[johnfairh]

Well, neither of those ideas speak to why your project is the only one affected, but the change is good & will hopefully help others in the future too -- thank you for the PR!