Conversation
3de1e58 to
6b42169
Compare
8d16e9a to
d3fa1ed
Compare
d3fa1ed to
e00993e
Compare
e00993e to
1f2f87e
Compare
|
Hey @johnfairh! I'd appreciate your feedback on this PR and the other PRs building on top of it. 🙏 |
|
All the attribute / version / fixtures stuff looks good - the way I handled the WinSDK issue before is to shim them enough to make macOS SourceKit happy with the types. In hindsight I ought to have added a comment to the failing test as well... I think this a bit more future-proof than rummaging through the json & keeping track of which / how many errors we expect - if the windows people do get interested in sourcekitten again then maybe they can centralise the shims or figure out a better approach. This at the top of WindowsError.swift means the #if !os(Windows)
// Shims for !windows SourceKit - see LibraryWrapperGeneratorTests.testLibraryWrappersAreUpToDate
private typealias WORD = UInt
private typealias DWORD = WORD
private typealias WCHAR = WORD
private let FORMAT_MESSAGE_ALLOCATE_BUFFER = 0
private let FORMAT_MESSAGE_FROM_SYSTEM = 0
private let FORMAT_MESSAGE_IGNORE_INSERTS = 0
private func FormatMessageW(_ a: DWORD, _ b: Int?, _ c: DWORD, _ d: DWORD, _ e: Any?, _ f: Int, _ g: Int?) -> DWORD { 0 }
#endif |
Thank you for the tip. That works without changes in the test. |
001bd13 to
d897c75
Compare
d897c75 to
7e40065
Compare
|
@SimplyDanny looks good. I’ll merge this; 827 & 829 should be good to rebase after that. #830 - SWXMLHash has a cocoapods implication - what’s the reason for updating that one? (depending on the reason we could maybe leave cocoapods sourcekitten with the ~>7 rule) Then we can ping JP & see if he has time to do a release - if not we can figure that out. |
Done.
I closed the PR. Cannot remember the reason for updating it.
I'd love to see a new release once #827 is merged. |
|
Hi @jpsim - we could do with a SourceKitten release if you have time - let us know if not & I'll can have a go at it. |
|
OK I did the thing - just another light release like the last few. |
Thank you, @johnfairh! 🎉 |
14.x versions are no longer available on macOS 14 images as can be seen in a recent PR build.
Building successfully with Xcode 16 requires to update a few test dependencies. It especially seems to have issues parsing files with unknown dependencies now.