Change sourcekitd_* functions to public#488
Closed
norio-nomura wants to merge 1 commit intomasterfrom
Closed
Conversation
Collaborator
Author
|
Closing since #487 was closed. |
Contributor
|
Oh, I thought this change was still valid. For example you can create a Without this PR it makes little sense for |
Collaborator
Author
|
Sorry, reopened. |
Collaborator
Author
|
As a personal opinion, I would like to recommend #490 than this. |
Owner
|
Agreed, let's pursue #490 over this. Thanks for leading the charge, @norio-nomura. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #487