Skip to content

[WIP] Typed declarations.#112

Closed
paulyoung wants to merge 2 commits intojpsim:masterfrom
paulyoung:typed-declarations
Closed

[WIP] Typed declarations.#112
paulyoung wants to merge 2 commits intojpsim:masterfrom
paulyoung:typed-declarations

Conversation

@paulyoung
Copy link
Contributor

@paulyoung paulyoung commented Dec 4, 2015

This relates to #87.

I've added FIXMEs where I ran into hurdles that didn't have an easy immediate fix (or I wasn't sure what to do) just to get something started.

paulyoung
paulyoung reviewed Dec 4, 2015
View reviewed changes
Source/SourceKittenFramework/ObjCDeclaration.swift
Copy link
Contributor Author

@paulyoung paulyoung Dec 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because the expected type here DeclarationKindType.

paulyoung
paulyoung reviewed Dec 4, 2015
View reviewed changes
Source/SourceKittenFramework/SwiftDeclaration.swift
Copy link
Contributor Author

@paulyoung paulyoung Dec 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure that this is the right thing to do here.

Copy link
Contributor Author

@paulyoung paulyoung Dec 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW .map(UInt32.init) didn't work here ¯_(ツ)_/¯

@paulyoung
Copy link
Contributor Author

paulyoung commented Dec 6, 2015

@jpsim any more thoughts on this since we last spoke? Would love to keep moving forward if we can.

@jpsim
Copy link
Owner

jpsim commented Dec 8, 2015

@jpsim any more thoughts on this since we last spoke? Would love to keep moving forward if we can.

Yes, sorry for the delay. What about our conversation about having a single Declaration type with a language switch property?

@paulyoung
Copy link
Contributor Author

paulyoung commented Dec 8, 2015

I'll try something to that effect later tonight.

@paulyoung paulyoung mentioned this pull request Dec 10, 2015
Open
@paulyoung
Copy link
Contributor Author

paulyoung commented Dec 10, 2015

I took a shot at this in paulyoung#2.

@paulyoung paulyoung mentioned this pull request Aug 22, 2016
Open
@eugeneego eugeneego mentioned this pull request May 1, 2017
Open
@jpsim
Copy link
Owner

jpsim commented Nov 10, 2017

We'll probably never revive this as-is, closing. #428 shows promise though and is along these lines.

Thanks anyway Paul!

@jpsim jpsim closed this Nov 10, 2017
SteffenL pushed a commit to SteffenL/SourceKitten that referenced this pull request Feb 13, 2019
@jpsim
- bump sourcekitten to 0.2.1 to improve declarations
91e0133 
- no more <<error type>> or default
- closes jpsim#65 and jpsim#112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@paulyoung @jpsim