change defqueries to return table of fns#2
Open
jonesmelton wants to merge 2 commits intojoy-framework:masterfrom
Open
change defqueries to return table of fns#2jonesmelton wants to merge 2 commits intojoy-framework:masterfrom
jonesmelton wants to merge 2 commits intojoy-framework:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes
suresql/defqueriesto return a table of queries, as well as defining them globally. I considered using a :local flag in the options struct to switch between the two, but since the return value is currently always nil I don't believe this breaks any of the API. I can still switch it back to that if it's preferable though.Uses:
with-dynsis used.I don't know why I had to change the imports in the tests, I was getting "could not find module" errors. I'm new to janet and have only used import with a relative path symbol, not a string. Maybe it's just an incompatibility with an older version? I'm on 1.25.1-meson. Again if that style is preferred I'm happy to change it back.