Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I can see you already handled #1 (Thanks for that!)
While I was looking at the code, I was just doing random refactors here and there.
I figured I might as well PR some of the formatting changes and refactors that I'd done so far.
Formatting/Refactors
The main thing was just to 2 series of
if/else.A bit simpler. ^-^'
The rest was just formatting, i.e. redundant line breaks or inconsistent spacing.
EditorConfig
Adds an EditorConfig file, so contributors can use consistent code styles with the rest of the project.
This makes it more convenient to work on the project when a developer's editor settings aren't the same as yours.
EditorConfig is a widely supported format that code editors use to override user preferences to adhere to project conventions.
The current settings are based on what I can see from exploring the repository, you may wish to modify the rules.
Welcome to tell me to remove one of the commits.