Remove duplicated test block#2062
Merged
Merged
Conversation
For some reason the full body of
elpy-black-fix-code-should-do-nothing-if-already-formatted was
duplicated identically and the github test runner action is generating
a stack trace for the error.
Error: error ("Test ‘elpy-black-fix-code-should-do-nothing-if-already-formatted’ redefined (or loaded twice)")
mapbacktrace(#f(compiled-function (evald func args flags) #<bytecode 0x1f93647adbae8641>))
debug-early-backtrace()
debug-early(error (error "Test ‘elpy-black-fix-code-should-do-nothing-if-already-formatted’ redefined (or loaded twice)"))
signal(error ("Test ‘elpy-black-fix-code-should-do-nothing-if-already-formatted’ redefined (or loaded twice)"))
error("Test `%s' redefined (or loaded twice)" elpy-black-fix-code-should-do-nothing-if-already-formatted)
Contributor
Author
|
That was a fast merge. :) I've found I like elpy more than dealing with eglot over tramp, so I decided to see how many test failures I can slowly fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason the full body of
elpy-black-fix-code-should-do-nothing-if-already-formatted was duplicated identically and the github test runner action is generating a stack trace for the error.
If you look directly above the deleted code you'll see an identical copy of the conditional code block.
PR Summary
PR checklist
Please make sure that the following things have been addressed (and check the relevant checkboxes):
One more test failure fixed.
I couldn't duplicate it with running ert directly, so I pushed it to the master branch of my fork where the github workflow ran and after the patch, the test
elpy-black-fix-code-should-do-nothing-if-already-formattedpassed