Skip to content

Remove duplicated test block#2062

Merged
gopar merged 1 commit into
jorgenschaefer:masterfrom
detrout:remove-duplicated-tests
Apr 15, 2026
Merged

Remove duplicated test block#2062
gopar merged 1 commit into
jorgenschaefer:masterfrom
detrout:remove-duplicated-tests

Conversation

@detrout
Copy link
Copy Markdown
Contributor

@detrout detrout commented Apr 15, 2026

For some reason the full body of
elpy-black-fix-code-should-do-nothing-if-already-formatted was duplicated identically and the github test runner action is generating a stack trace for the error.

If you look directly above the deleted code you'll see an identical copy of the conditional code block.

  Error: error ("Test ‘elpy-black-fix-code-should-do-nothing-if-already-formatted’ redefined (or loaded twice)")
    mapbacktrace(#f(compiled-function (evald func args flags) #<bytecode 0x1f93647adbae8641>))
    debug-early-backtrace()
    debug-early(error (error "Test ‘elpy-black-fix-code-should-do-nothing-if-already-formatted’ redefined (or loaded twice)"))
    signal(error ("Test ‘elpy-black-fix-code-should-do-nothing-if-already-formatted’ redefined (or loaded twice)"))
    error("Test `%s' redefined (or loaded twice)" elpy-black-fix-code-should-do-nothing-if-already-formatted)

PR Summary

PR checklist

Please make sure that the following things have been addressed (and check the relevant checkboxes):

  • Commits respect our guidelines
  • [?] Tests are passing properly (see here on how to run Elpy's tests)

One more test failure fixed.

I couldn't duplicate it with running ert directly, so I pushed it to the master branch of my fork where the github workflow ran and after the patch, the test elpy-black-fix-code-should-do-nothing-if-already-formatted passed

For some reason the full body of
elpy-black-fix-code-should-do-nothing-if-already-formatted was
duplicated identically and the github test runner action is generating
a stack trace for the error.

  Error: error ("Test ‘elpy-black-fix-code-should-do-nothing-if-already-formatted’ redefined (or loaded twice)")
    mapbacktrace(#f(compiled-function (evald func args flags) #<bytecode 0x1f93647adbae8641>))
    debug-early-backtrace()
    debug-early(error (error "Test ‘elpy-black-fix-code-should-do-nothing-if-already-formatted’ redefined (or loaded twice)"))
    signal(error ("Test ‘elpy-black-fix-code-should-do-nothing-if-already-formatted’ redefined (or loaded twice)"))
    error("Test `%s' redefined (or loaded twice)" elpy-black-fix-code-should-do-nothing-if-already-formatted)
@gopar gopar merged commit 3b3394e into jorgenschaefer:master Apr 15, 2026
0 of 35 checks passed
@detrout
Copy link
Copy Markdown
Contributor Author

detrout commented Apr 15, 2026

That was a fast merge. :)

I've found I like elpy more than dealing with eglot over tramp, so I decided to see how many test failures I can slowly fix.

@detrout detrout deleted the remove-duplicated-tests branch April 15, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants