Add ability to pass in custom Java Options #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hi, I've added the ability to supply custom jvm options to allow different spring boot profiles ot be selected, which means the app can be run within openshift or standlaone, yet still function. e.g. -Dspring.profiles.active=local or -Dspring.profiles.active=oshift |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to pass in custom Java options, e.g. for activating different Spring Boot Profiles. This allows an app e.g. to run in detached mode on a laptop standalone not on Openshift or Minishift - yet alternatively run on Openshift too for example to read env vars for accessing db credentials.
example project: https://github.com/Sufyaan-Kazi/spring-boot-cities-service/tree/openshift