Refactor sarifReportFinder.ts to use promises when reading a directory #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This changes the reading of a directory for SARIF files to use promises, which allows us to read it asynchronously.
This also coincidentally fixes a bug where running the binary in Windows while using the option
--sarif-directory ".\"caused the program to log "SARIF files detected: []" regardless of what it actually found (the program seems to work correctly despite it logging erroneously). I suspect it has something to do with the way something else in the program parses".\"but I didn't investigate further since it went away after exchangingfs.readdirSync()forfs.promises.readdir().Your fork seems to be more actively maintained than the base repository from Peter Murray, so that's why I built on top of your work :)