fix(cli): improve --etag-save error path handling (test 369)#132
Merged
jonwiggins merged 1 commit intomainfrom Mar 28, 2026
Merged
Conversation
… 369)
Instead of only checking parent directory existence, try to actually open
the etag file upfront (matching curl's fopen("ab") in etag_store). This
catches permission errors and other failure modes beyond missing parent
directories. Also adds proper warning/error messages for the single-URL
case matching curl's output format.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--etag-saveerror path handling to match curl's behavior by actually trying to open the file upfront (like curl'sfopen("ab")inetag_store) instead of only checking parent directory existenceCloses #112
Test plan
--etag-save with bad path then working transfer) passes--etag-save with bad path - no transfer) passescargo clippycleancargo fmtcleancargo test -p urlx-cli— 345 tests pass🤖 Generated with Claude Code